HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
infraio
approved these changes
Aug 14, 2019
Apache9
requested changes
Aug 14, 2019
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventType.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
| @@ -1431,6 +1431,8 @@ private void startServiceThreads() throws IOException{ | |||
| conf.getInt("hbase.master.executor.meta.serverops.threads", 5)); | |||
| this.executorService.startExecutorService(ExecutorType.M_LOG_REPLAY_OPS, | |||
| conf.getInt("hbase.master.executor.logreplayops.threads", 10)); | |||
| this.executorService.startExecutorService(ExecutorType.MASTER_SNAPSHOT_OPERATIONS, | |||
| conf.getInt("hbase.master.executor.snapshot.threads", 3)); | |||
There was a problem hiding this comment.
Better make a static field for this.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
But please fix the checkstyle issues before merging... |
|
The checkstyle is not an issue I think, the '(' is preceded by a whitespace because we want to make the code align as before : /**
* Messages originating from Client to Master.<br>
* C_M_CREATE_TABLE<br>
* Client asking Master to create a table.
*/
C_M_CREATE_TABLE (47, ExecutorType.MASTER_TABLE_OPERATIONS),
/**
* Messages originating from Client to Master.<br>
* C_M_SNAPSHOT_TABLE<br>
* Client asking Master to snapshot an offline table.
*/
C_M_SNAPSHOT_TABLE (48, ExecutorType.MASTER_SNAPSHOT_OPERATIONS),
/**
* Messages originating from Client to Master.<br>
* C_M_RESTORE_SNAPSHOT<br>
* Client asking Master to restore a snapshot.
*/
C_M_RESTORE_SNAPSHOT (49, ExecutorType.MASTER_SNAPSHOT_OPERATIONS), |
|
💔 -1 overall
This message was automatically generated. |
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…oring snapshot (apache#486) (cherry picked from commit b4734e7) Change-Id: Id5c952da1949f7039d6caa5329c6599ca54fbba4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oring snapshot