HBASE-27646 Should not use pread when prefetching in HFilePreadReader #5063

sunhelly · 2023-02-27T11:14:43Z

Using isolate stream reader for prefetching in pread reader, to speed up the prefetching progress.
The blocks cached when prefetching will be released after the pread reader is closed.

Apache-HBase · 2023-02-27T12:20:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 27s	master passed
+1 💚	compile	2m 52s	master passed
+1 💚	checkstyle	0m 43s	master passed
+1 💚	spotless	0m 50s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 54s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	2m 48s	the patch passed
+1 💚	javac	2m 48s	the patch passed
+1 💚	checkstyle	0m 40s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 21s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		45m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 66c5a43ab9ac 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `10037df`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-27T16:06:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 16s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	shadedjars	6m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	0m 53s	the patch passed
+1 💚	javac	0m 53s	the patch passed
+1 💚	shadedjars	6m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
-1 ❌	unit	234m 19s	hbase-server in the patch failed.
		263m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dcfbb7d6b779 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `10037df`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/testReport/
Max. process+thread count	2663 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-27T16:48:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 52s	master passed
+1 💚	compile	1m 14s	master passed
+1 💚	shadedjars	6m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 24s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	5m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
-1 ❌	unit	262m 2s	hbase-server in the patch failed.
		293m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux faddcf3016a5 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `10037df`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/testReport/
Max. process+thread count	2500 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java

Apache-HBase · 2023-03-02T14:38:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 35s	master passed
+1 💚	compile	2m 24s	master passed
+1 💚	checkstyle	0m 35s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	2m 20s	the patch passed
+1 💚	javac	2m 20s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 43s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 34s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		38m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ed095061148e 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-02T17:43:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 42s	master passed
+1 💚	compile	0m 42s	master passed
+1 💚	shadedjars	4m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 12s	the patch passed
+1 💚	compile	0m 41s	the patch passed
+1 💚	javac	0m 41s	the patch passed
+1 💚	shadedjars	4m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	199m 35s	hbase-server in the patch passed.
		224m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5273a7ac57e5 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/2/testReport/
Max. process+thread count	2601 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-02T17:53:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 9s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	0m 42s	the patch passed
+1 💚	javac	0m 42s	the patch passed
+1 💚	shadedjars	5m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	209m 14s	hbase-server in the patch passed.
		234m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 924caba0124e 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2b0074`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/2/testReport/
Max. process+thread count	2641 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java

Apache-HBase · 2023-03-06T05:57:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 32s	master passed
+1 💚	compile	3m 29s	master passed
+1 💚	checkstyle	0m 48s	master passed
+1 💚	spotless	1m 7s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 17s	the patch passed
+1 💚	compile	3m 26s	the patch passed
+1 💚	javac	3m 26s	the patch passed
+1 💚	checkstyle	1m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 33s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 59s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 21s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		56m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c669005bedaf 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `37858bb`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-06T09:14:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 25s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	shadedjars	4m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	4m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	231m 22s	hbase-server in the patch passed.
		253m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 65320223f263 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `37858bb`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/testReport/
Max. process+thread count	2649 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-06T09:16:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 34s	master passed
+1 💚	compile	0m 48s	master passed
+1 💚	shadedjars	4m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	4m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
-1 ❌	unit	232m 6s	hbase-server in the patch failed.
		255m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5063
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 13dbdd67f000 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `37858bb`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/testReport/
Max. process+thread count	2684 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5063/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly · 2023-03-15T03:14:16Z

The failed UTs are not relevant to this PR, and all passed in local tests.
Ping @bbeaudreault @Apache9 , if there are any other concerns, please let me know. Thanks.

bbeaudreault

lgtm, thanks

…apache#5063) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…#5063) (#5122) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…#5063) (#5123) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…#5063) (#5124) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…apache#5063) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…apache#5063) (apache#5123) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit fde0f4b) Change-Id: Id727198b9ef22a293f0984521bd6816266b106cb

Apache9 reviewed Feb 28, 2023

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java Outdated Show resolved Hide resolved

sunhelly force-pushed the HBASE-27646 branch from e1b9bd6 to 9cf45d0 Compare March 2, 2023 11:07

bbeaudreault reviewed Mar 3, 2023

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java Outdated Show resolved Hide resolved

bbeaudreault reviewed Mar 3, 2023

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java Outdated Show resolved Hide resolved

HBASE-27646 Should not use pread when prefetching in HFilePreadReader

52c74aa

sunhelly force-pushed the HBASE-27646 branch from 9cf45d0 to 52c74aa Compare March 6, 2023 04:48

bbeaudreault approved these changes Mar 17, 2023

View reviewed changes

sunhelly merged commit 201846b into apache:master Mar 20, 2023

sunhelly added a commit to sunhelly/hbase that referenced this pull request Mar 20, 2023

HBASE-27646 Should not use pread when prefetching in HFilePreadReader (…

d72d90c

…apache#5063) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

sunhelly mentioned this pull request Mar 20, 2023

Backport HBASE-27646, Should not use pread when prefetching in HFilePreadReader… #5122

Merged

sunhelly added a commit to sunhelly/hbase that referenced this pull request Mar 20, 2023

HBASE-27646 Should not use pread when prefetching in HFilePreadReader (…

6d32641

…apache#5063) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

sunhelly added a commit to sunhelly/hbase that referenced this pull request Mar 20, 2023

HBASE-27646 Should not use pread when prefetching in HFilePreadReader (…

2933be3

…apache#5063) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

sunhelly mentioned this pull request Mar 20, 2023

Backport 'HBASE-27646 Should not use pread when prefetching in HFilePreadReader… #5123

Merged

sunhelly added a commit to sunhelly/hbase that referenced this pull request Mar 20, 2023

HBASE-27646 Should not use pread when prefetching in HFilePreadReader (…

b1033bd

…apache#5063) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

sunhelly mentioned this pull request Mar 20, 2023

Backport 'HBASE-27646 Should not use pread when prefetching in HFilePreadReader… #5124

Merged

sunhelly added a commit that referenced this pull request Mar 20, 2023

HBASE-27646 Should not use pread when prefetching in HFilePreadReader (…

873f898

…#5063) (#5122) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

sunhelly added a commit that referenced this pull request Mar 20, 2023

HBASE-27646 Should not use pread when prefetching in HFilePreadReader (…

fde0f4b

…#5063) (#5123) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

sunhelly added a commit that referenced this pull request Mar 20, 2023

HBASE-27646 Should not use pread when prefetching in HFilePreadReader (…

0bc7f56

…#5063) (#5124) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

wesiq pushed a commit to web-iq/hbase that referenced this pull request Mar 27, 2023

HBASE-27646 Should not use pread when prefetching in HFilePreadReader (…

7525a00

…apache#5063) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27646 Should not use pread when prefetching in HFilePreadReader #5063

HBASE-27646 Should not use pread when prefetching in HFilePreadReader #5063

sunhelly commented Feb 27, 2023

Apache-HBase commented Feb 27, 2023

Apache-HBase commented Feb 27, 2023

Apache-HBase commented Feb 27, 2023

Apache-HBase commented Mar 2, 2023

Apache-HBase commented Mar 2, 2023

Apache-HBase commented Mar 2, 2023

Apache-HBase commented Mar 6, 2023

Apache-HBase commented Mar 6, 2023

Apache-HBase commented Mar 6, 2023

sunhelly commented Mar 15, 2023

bbeaudreault left a comment

HBASE-27646 Should not use pread when prefetching in HFilePreadReader #5063

HBASE-27646 Should not use pread when prefetching in HFilePreadReader #5063

Conversation

sunhelly commented Feb 27, 2023

Apache-HBase commented Feb 27, 2023

Apache-HBase commented Feb 27, 2023

Apache-HBase commented Feb 27, 2023

Apache-HBase commented Mar 2, 2023

Apache-HBase commented Mar 2, 2023

Apache-HBase commented Mar 2, 2023

Apache-HBase commented Mar 6, 2023

Apache-HBase commented Mar 6, 2023

Apache-HBase commented Mar 6, 2023

sunhelly commented Mar 15, 2023

bbeaudreault left a comment

Choose a reason for hiding this comment