HBASE-22879 user_permission command failed to show global permission #511

mymeiyi · 2019-08-19T04:18:07Z

No description provided.

Apache-HBase · 2019-08-19T05:22:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	129	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	377	master passed
+1	compile	25	master passed
+1	checkstyle	14	master passed
+1	shadedjars	278	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	17	master passed
0	spotbugs	297	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	0	master passed
		_ Patch Compile Tests _
+1	mvninstall	345	the patch passed
+1	compile	23	the patch passed
+1	javac	23	the patch passed
+1	checkstyle	12	the patch passed
-1	rubocop	35	The patch generated 22 new + 67 unchanged - 3 fixed = 89 total (was 70)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	271	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1072	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	11	the patch passed
+1	findbugs	0	the patch passed
		_ Other Tests _
+1	unit	597	hbase-shell in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		3761

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/1/artifact/out/Dockerfile
GITHUB PR	#511
Optional Tests	dupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1923f91b0bc3 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revision	master / `7697d48`
Default Java	1.8.0_181
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/1/artifact/out/diff-patch-rubocop.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/1/testReport/
Max. process+thread count	2552 (vs. ulimit of 10000)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-19T17:25:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	61	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	335	master passed
+1	compile	23	master passed
+1	checkstyle	12	master passed
+1	shadedjars	277	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	13	master passed
0	spotbugs	292	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	0	master passed
		_ Patch Compile Tests _
+1	mvninstall	341	the patch passed
+1	compile	23	the patch passed
+1	javac	23	the patch passed
+1	checkstyle	10	the patch passed
-1	rubocop	7	The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	298	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	953	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	13	the patch passed
+1	findbugs	0	the patch passed
		_ Other Tests _
+1	unit	570	hbase-shell in the patch passed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		3320

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/3/artifact/out/Dockerfile
GITHUB PR	#511
Optional Tests	dupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b7d8194c3f49 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revision	master / `46abaef`
Default Java	1.8.0_181
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/3/artifact/out/diff-patch-rubocop.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/3/testReport/
Max. process+thread count	2577 (vs. ulimit of 10000)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-19T20:58:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	92	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	367	master passed
+1	compile	23	master passed
+1	checkstyle	12	master passed
+1	shadedjars	309	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	16	master passed
0	spotbugs	327	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	0	master passed
		_ Patch Compile Tests _
+1	mvninstall	348	the patch passed
+1	compile	29	the patch passed
+1	javac	29	the patch passed
+1	checkstyle	13	the patch passed
-1	rubocop	7	The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	314	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1051	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	12	the patch passed
+1	findbugs	0	the patch passed
		_ Other Tests _
+1	unit	502	hbase-shell in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3526

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/4/artifact/out/Dockerfile
GITHUB PR	#511
Optional Tests	dupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 2cc6e8921eed 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revision	master / `8e488ce`
Default Java	1.8.0_181
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/4/artifact/out/diff-patch-rubocop.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/4/testReport/
Max. process+thread count	2517 (vs. ulimit of 10000)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-19T22:58:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	83	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	418	master passed
+1	compile	23	master passed
+1	checkstyle	12	master passed
+1	shadedjars	297	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	13	master passed
0	spotbugs	312	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	0	master passed
		_ Patch Compile Tests _
+1	mvninstall	309	the patch passed
+1	compile	23	the patch passed
+1	javac	23	the patch passed
+1	checkstyle	10	the patch passed
-1	rubocop	25	The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	287	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	974	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	13	the patch passed
+1	findbugs	0	the patch passed
		_ Other Tests _
+1	unit	615	hbase-shell in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3511

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/artifact/out/Dockerfile
GITHUB PR	#511
Optional Tests	dupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 53d5983804fb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revision	master / `6738280`
Default Java	1.8.0_181
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/artifact/out/diff-patch-rubocop.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/testReport/
Max. process+thread count	2523 (vs. ulimit of 10000)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-20T05:43:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	66	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	319	master passed
+1	compile	21	master passed
+1	checkstyle	10	master passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	13	master passed
0	spotbugs	285	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	0	master passed
		_ Patch Compile Tests _
+1	mvninstall	303	the patch passed
+1	compile	22	the patch passed
+1	javac	22	the patch passed
+1	checkstyle	10	the patch passed
-1	rubocop	5	The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedjars	280	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	945	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	12	the patch passed
+1	findbugs	0	the patch passed
		_ Other Tests _
+1	unit	603	hbase-shell in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		3260

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/artifact/out/Dockerfile
GITHUB PR	#511
Optional Tests	dupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6fe1fa90ea8a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revision	master / `a59f7d4`
Default Java	1.8.0_181
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/artifact/out/diff-patch-rubocop.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/testReport/
Max. process+thread count	2526 (vs. ulimit of 10000)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd · 2019-08-20T07:12:44Z

hbase-shell/src/test/java/org/apache/hadoop/hbase/client/TestShell.java

@@ -35,7 +35,7 @@
  @Test
  public void testRunShellTests() throws IOException {
    System.setProperty("shell.test.exclude", "replication_admin_test.rb,rsgroup_shell_test.rb," +
-      "admin_test.rb,table_test.rb,quotas_test.rb");
+      "admin_test.rb,table_test.rb,quotas_test.rb,admin2_test.rb");


What's the story of admin2_test.rb, why is it related to this fix?

It's not related to this fix. But admin2_test.rb is already tested in TestAdminShell2, TestShell can skip it rather than test it twice?

Reidddddd

+1

Apache-HBase · 2019-08-20T18:10:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	61	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	372	master passed
+1	compile	24	master passed
+1	checkstyle	11	master passed
+1	shadedjars	301	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	15	master passed
0	spotbugs	319	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	0	master passed
		_ Patch Compile Tests _
+1	mvninstall	336	the patch passed
+1	compile	22	the patch passed
+1	javac	22	the patch passed
+1	checkstyle	10	the patch passed
-1	rubocop	6	The patch generated 3 new + 67 unchanged - 3 fixed = 70 total (was 70)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	276	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	943	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	0	the patch passed
		_ Other Tests _
+1	unit	745	hbase-shell in the patch passed.
+1	asflicense	17	The patch does not generate ASF License warnings.
		3613

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/7/artifact/out/Dockerfile
GITHUB PR	#511
Optional Tests	dupname asflicense javac javadoc unit rubocop spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 90009fb56837 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-511/out/precommit/personality/provided.sh
git revision	master / `ab28f9d`
Default Java	1.8.0_181
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/7/artifact/out/diff-patch-rubocop.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/7/testReport/
Max. process+thread count	2528 (vs. ulimit of 10000)
modules	C: hbase-shell U: hbase-shell
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-511/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…511)

…pache#511)

…pache#511) (cherry picked from commit 947f6d4) Change-Id: If5de4d376b78a7a13ac26321a464dc91ae12f9de

HBASE-22879 user_permission command failed to show global permission

01eeee5

mymeiyi force-pushed the user-permission branch from 5803246 to 01eeee5 Compare August 19, 2019 06:59

Reidddddd requested changes Aug 20, 2019

View reviewed changes

Reidddddd approved these changes Aug 20, 2019

View reviewed changes

mymeiyi merged commit 66ad42c into apache:master Aug 21, 2019

mymeiyi added a commit that referenced this pull request Aug 21, 2019

HBASE-22879 user_permission command failed to show global permission (#…

947f6d4

…511)

mymeiyi added a commit that referenced this pull request Aug 21, 2019

HBASE-22879 user_permission command failed to show global permission (#…

9d178cf

…511)

mymeiyi deleted the user-permission branch September 4, 2019 06:47

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-22879 user_permission command failed to show global permission (a…

63159cc

…pache#511)

symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021

HBASE-22879 user_permission command failed to show global permission (a…

57aa791

…pache#511) (cherry picked from commit 947f6d4) Change-Id: If5de4d376b78a7a13ac26321a464dc91ae12f9de

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22879 user_permission command failed to show global permission #511

HBASE-22879 user_permission command failed to show global permission #511

mymeiyi commented Aug 19, 2019

Apache-HBase commented Aug 19, 2019

Apache-HBase commented Aug 19, 2019

Apache-HBase commented Aug 19, 2019

Apache-HBase commented Aug 19, 2019

Apache-HBase commented Aug 20, 2019

Reidddddd Aug 20, 2019

mymeiyi Aug 20, 2019

Reidddddd left a comment

Apache-HBase commented Aug 20, 2019

HBASE-22879 user_permission command failed to show global permission #511

HBASE-22879 user_permission command failed to show global permission #511

Conversation

mymeiyi commented Aug 19, 2019

Apache-HBase commented Aug 19, 2019

Apache-HBase commented Aug 19, 2019

Apache-HBase commented Aug 19, 2019

Apache-HBase commented Aug 19, 2019

Apache-HBase commented Aug 20, 2019

Reidddddd Aug 20, 2019

Choose a reason for hiding this comment

mymeiyi Aug 20, 2019

Choose a reason for hiding this comment

Reidddddd left a comment

Choose a reason for hiding this comment

Apache-HBase commented Aug 20, 2019