-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent … #520
Conversation
…code coverage and removed two methods from ResulStatsUtil
💔 -1 overall
This message was automatically generated. |
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Show resolved
Hide resolved
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Outdated
Show resolved
Hide resolved
@HorizonNet |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Outdated
Show resolved
Hide resolved
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Outdated
Show resolved
Hide resolved
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Outdated
Show resolved
Hide resolved
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Outdated
Show resolved
Hide resolved
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Outdated
Show resolved
Hide resolved
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Outdated
Show resolved
Hide resolved
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestResultStatsUtil.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs @HorizonNet to approve.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@saintstack I'll make the requested changes in Murtaza's branch and will commit if QA doesn't complain. The removals should be fine as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending QA.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…atsUtil (#520) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…atsUtil (#520) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…atsUtil (#520) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…atsUtil (apache#520) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…atsUtil (apache#520) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 024a273) Change-Id: I017a35e5d339d539d4b5a8730c15f9da29262204
…code coverage and removed two methods from ResulStatsUtil