Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (addendum) #5200

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

ndimiduk
Copy link
Member

Make use of %notEmpty pattern with MDC logging. Will function as expected once we upgrade to Log4J 2.21.0+.

@ndimiduk ndimiduk requested a review from Apache9 April 24, 2023 12:10
@ndimiduk ndimiduk changed the title HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (adendum) HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (addendum) Apr 24, 2023
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 spotless 0m 39s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 35s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
3m 25s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5200
Optional Tests dupname asflicense spotless
uname Linux 210d345c93c1 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 95f83cb
Max. process+thread count 43 (vs. ulimit of 30000)
modules C: . hbase-logging U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…(addendum)

Make use of `%notEmpty` pattern with MDC logging. Will function as expected once we upgrade to
Log4J 2.21.0+.
@ndimiduk ndimiduk force-pushed the 27762-mdc-logging-adendum branch from 14e0762 to 5d5c1b6 Compare April 24, 2023 12:24
Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with log4j 2.20.1-SNAPSHOT, at least it worked when running UTs without the proper MDC properties.

+1. Let's keep an eye on the new release for log4j2.

@ndimiduk ndimiduk merged commit 2216414 into apache:master Apr 24, 2023
@ndimiduk ndimiduk deleted the 27762-mdc-logging-adendum branch April 24, 2023 15:55
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 50s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 32s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 18s the patch passed
_ Other Tests _
+1 💚 unit 266m 53s root in the patch passed.
281m 9s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5200
Optional Tests unit
uname Linux b6df4b8ef593 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 95f83cb
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/testReport/
Max. process+thread count 4601 (vs. ulimit of 30000)
modules C: hbase-logging . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 24s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 3s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 45s the patch passed
_ Other Tests _
+1 💚 unit 399m 43s root in the patch passed.
412m 51s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5200
Optional Tests unit
uname Linux 40a2c4a07f9d 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 95f83cb
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/testReport/
Max. process+thread count 5093 (vs. ulimit of 30000)
modules C: hbase-logging . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5200/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants