HBASE-27812 Provide option in HBase UI to disable stack trace for security #5205

ydodeja365 · 2023-04-27T06:30:10Z

No description provided.

…urity

Apache-HBase · 2023-04-27T07:48:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 52s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 1s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s	master passed
+1 💚	compile	4m 48s	master passed
+1 💚	checkstyle	1m 6s	master passed
+0 🆗	refguide	2m 46s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 46s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	4m 48s	the patch passed
+1 💚	javac	4m 48s	the patch passed
+1 💚	checkstyle	1m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	2m 13s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 23s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		62m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname	Linux 805420849b95 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3593288`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/1/yetus-general-check/output/branch-site/book.html
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/1/yetus-general-check/output/patch-site/book.html
Max. process+thread count	177 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil

Please provide steps on how the issue can be reproduced without your fix, so that this can be tested.

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java

Apache-HBase · 2023-04-27T11:41:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 3s	master passed
+1 💚	compile	1m 51s	master passed
+1 💚	shadedjars	4m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 59s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	1m 55s	the patch passed
+1 💚	javac	1m 55s	the patch passed
+1 💚	shadedjars	4m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	263m 10s	root in the patch passed.
		296m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c8aaf1f2aaa6 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3593288`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/1/testReport/
Max. process+thread count	4717 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ydodeja365 · 2023-05-02T15:26:54Z

Please provide steps on how the issue can be reproduced without your fix, so that this can be tested.

@wchevreuil I reproduced this issue by following these steps:

Enable SSL for HBase UI (in order to enable SNI check using SecureRequestCustomizer)
Send a curl request to any HBase UI endpoint explicitly providing the following host header: -H "Host: attackers.com"
Response will contain entire stack trace in old behaviour or if property is false, and will not contain stack trace if true

Apache-HBase · 2023-05-02T16:08:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	master passed
+1 💚	compile	1m 44s	master passed
+1 💚	shadedjars	4m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 52s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
-1 ❌	mvninstall	1m 28s	root in the patch failed.
-1 ❌	compile	0m 38s	root in the patch failed.
-0 ⚠️	javac	0m 38s	root in the patch failed.
-1 ❌	shadedjars	2m 21s	patch has 14 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 8s	hbase-http in the patch failed.
-0 ⚠️	javadoc	0m 31s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	14m 5s	root in the patch failed.
		33m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 599a3c45b07a 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/testReport/
Max. process+thread count	488 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-02T16:10:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 48s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 21s	master passed
+1 💚	compile	4m 43s	master passed
+1 💚	checkstyle	1m 5s	master passed
+0 🆗	refguide	2m 13s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 31s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
-1 ❌	mvninstall	1m 30s	root in the patch failed.
-1 ❌	compile	1m 17s	root in the patch failed.
-0 ⚠️	javac	1m 17s	root in the patch failed.
-0 ⚠️	checkstyle	0m 21s	The patch fails to run checkstyle in root
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	2m 11s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
-1 ❌	hadoopcheck	1m 30s	The patch causes 14 errors with Hadoop v3.2.4.
-1 ❌	hadoopcheck	2m 55s	The patch causes 14 errors with Hadoop v3.3.4.
-1 ❌	spotless	0m 17s	patch has 11 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	0m 12s	hbase-http in the patch failed.
-1 ❌	spotbugs	2m 33s	root in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		34m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname	Linux 95e8cd640356 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/2/yetus-general-check/output/branch-site/book.html
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/patch-compile-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/2/yetus-general-check/output/patch-site/book.html
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-http.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-general-check/output/patch-spotbugs-root.txt
Max. process+thread count	176 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-02T16:15:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s	master passed
+1 💚	compile	1m 52s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
-1 ❌	mvninstall	1m 37s	root in the patch failed.
-1 ❌	compile	0m 41s	root in the patch failed.
-0 ⚠️	javac	0m 41s	root in the patch failed.
-1 ❌	shadedjars	2m 30s	patch has 14 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 8s	hbase-http in the patch failed.
-0 ⚠️	javadoc	0m 32s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	17m 3s	root in the patch failed.
		40m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fee368cf11fa 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-http.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-root.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/testReport/
Max. process+thread count	488 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-02T19:06:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 22s	master passed
+1 💚	compile	4m 43s	master passed
+1 💚	checkstyle	1m 5s	master passed
+0 🆗	refguide	2m 13s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 31s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	4m 41s	the patch passed
+1 💚	javac	4m 41s	the patch passed
+1 💚	checkstyle	1m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	2m 16s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 27s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 57s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		61m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname	Linux 1ed724af45f6 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/3/yetus-general-check/output/branch-site/book.html
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/3/yetus-general-check/output/patch-site/book.html
Max. process+thread count	176 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-02T22:54:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 21s	master passed
+1 💚	compile	1m 43s	master passed
+1 💚	shadedjars	4m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 53s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 26s	the patch passed
+1 💚	compile	1m 45s	the patch passed
+1 💚	javac	1m 45s	the patch passed
+1 💚	shadedjars	4m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	258m 50s	root in the patch passed.
		289m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 81e4a8fa9ab6 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/3/testReport/
Max. process+thread count	5356 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T00:35:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 13s	master passed
+1 💚	compile	1m 36s	master passed
+1 💚	shadedjars	4m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 38s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	1m 36s	the patch passed
+1 💚	javac	1m 36s	the patch passed
+1 💚	shadedjars	4m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	361m 5s	root in the patch passed.
		389m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d86097eda2d5 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/3/testReport/
Max. process+thread count	4433 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T01:38:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s	master passed
+1 💚	compile	4m 46s	master passed
+1 💚	checkstyle	1m 7s	master passed
+0 🆗	refguide	2m 15s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 18s	the patch passed
+1 💚	compile	4m 55s	the patch passed
+1 💚	javac	4m 55s	the patch passed
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	2m 14s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 32s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	8m 3s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		61m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname	Linux c17ae21b2510 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/4/yetus-general-check/output/branch-site/book.html
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/4/yetus-general-check/output/patch-site/book.html
Max. process+thread count	176 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T04:48:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	1m 50s	master passed
+1 💚	shadedjars	4m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	compile	1m 51s	the patch passed
+1 💚	javac	1m 51s	the patch passed
+1 💚	shadedjars	4m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 56s	the patch passed
		_ Other Tests _
-1 ❌	unit	221m 25s	root in the patch failed.
		251m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 11a8edba6a79 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/testReport/
Max. process+thread count	2825 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T07:07:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 51s	master passed
+1 💚	compile	1m 33s	master passed
+1 💚	shadedjars	4m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s	the patch passed
+1 💚	compile	1m 35s	the patch passed
+1 💚	javac	1m 35s	the patch passed
+1 💚	shadedjars	4m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	362m 49s	root in the patch passed.
		390m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6acfec9b990f 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/testReport/
Max. process+thread count	4455 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ydodeja365 · 2023-05-04T04:36:34Z

@wchevreuil addressed all the comments, thanks for the review.

Apache-HBase · 2023-05-04T05:47:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s	master passed
+1 💚	compile	4m 46s	master passed
+1 💚	checkstyle	1m 5s	master passed
+0 🆗	refguide	2m 13s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 18s	the patch passed
+1 💚	compile	4m 50s	the patch passed
+1 💚	javac	4m 50s	the patch passed
+1 💚	checkstyle	1m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	2m 14s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 22s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 54s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		61m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname	Linux 76e467f67f34 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `216cdf9`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/5/yetus-general-check/output/branch-site/book.html
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5205/5/yetus-general-check/output/patch-site/book.html
Max. process+thread count	177 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-04T09:56:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 32s	master passed
+1 💚	compile	1m 49s	master passed
+1 💚	shadedjars	4m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 58s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	1m 53s	the patch passed
+1 💚	javac	1m 53s	the patch passed
+1 💚	shadedjars	4m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 58s	the patch passed
		_ Other Tests _
-1 ❌	unit	279m 52s	root in the patch failed.
		311m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fe1d98e2868a 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `216cdf9`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/testReport/
Max. process+thread count	4832 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-04T11:15:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 55s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 51s	master passed
+1 💚	compile	1m 33s	master passed
+1 💚	shadedjars	4m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	1m 35s	the patch passed
+1 💚	javac	1m 35s	the patch passed
+1 💚	shadedjars	4m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	361m 49s	root in the patch passed.
		390m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5205
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9ecfd0a37551 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `216cdf9`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/testReport/
Max. process+thread count	4519 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5205/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…urity (#5205) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit cf9684d)

HBASE-27812 Provide option in HBase UI to disable stack trace for sec…

3ea676d

…urity

wchevreuil reviewed Apr 27, 2023

View reviewed changes

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java Outdated Show resolved Hide resolved

hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java Outdated Show resolved Hide resolved

ydodeja365 force-pushed the HBASE-27812 branch from 045f837 to 3ea676d Compare May 2, 2023 18:01

Addressed review comments

921243f

Review comment for the if block

71fd968

Apache9 approved these changes May 14, 2023

View reviewed changes

Apache9 merged commit cf9684d into apache:master May 21, 2023

Apache9 pushed a commit that referenced this pull request May 21, 2023

HBASE-27812 Provide option in HBase UI to disable stack trace for sec…

bf07ff4

…urity (#5205) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit cf9684d)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27812 Provide option in HBase UI to disable stack trace for security #5205

HBASE-27812 Provide option in HBase UI to disable stack trace for security #5205

ydodeja365 commented Apr 27, 2023

Apache-HBase commented Apr 27, 2023

wchevreuil left a comment

Apache-HBase commented Apr 27, 2023

ydodeja365 commented May 2, 2023 •

edited

Loading

Apache-HBase commented May 2, 2023

Apache-HBase commented May 2, 2023

Apache-HBase commented May 2, 2023

Apache-HBase commented May 2, 2023

Apache-HBase commented May 2, 2023

Apache-HBase commented May 3, 2023

Apache-HBase commented May 3, 2023

Apache-HBase commented May 3, 2023

Apache-HBase commented May 3, 2023

ydodeja365 commented May 4, 2023

Apache-HBase commented May 4, 2023

Apache-HBase commented May 4, 2023

Apache-HBase commented May 4, 2023

HBASE-27812 Provide option in HBase UI to disable stack trace for security #5205

HBASE-27812 Provide option in HBase UI to disable stack trace for security #5205

Conversation

ydodeja365 commented Apr 27, 2023

Apache-HBase commented Apr 27, 2023

wchevreuil left a comment

Choose a reason for hiding this comment

Apache-HBase commented Apr 27, 2023

ydodeja365 commented May 2, 2023 • edited Loading

Apache-HBase commented May 2, 2023

Apache-HBase commented May 2, 2023

Apache-HBase commented May 2, 2023

Apache-HBase commented May 2, 2023

Apache-HBase commented May 2, 2023

Apache-HBase commented May 3, 2023

Apache-HBase commented May 3, 2023

Apache-HBase commented May 3, 2023

Apache-HBase commented May 3, 2023

ydodeja365 commented May 4, 2023

Apache-HBase commented May 4, 2023

Apache-HBase commented May 4, 2023

Apache-HBase commented May 4, 2023

ydodeja365 commented May 2, 2023 •

edited

Loading