HBASE-27852: Interrupt BucketCachePersister thread when BucketCache i… #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
May 11, 2023
Comment on lines
47
to
51
| } catch (IOException e) { | ||
| LOG.warn("IOException in BucketCachePersister" + e.getMessage()); | ||
| } catch (InterruptedException iex) { | ||
| LOG.warn("InterruptedException in BucketCachePersister" + iex.getMessage()); | ||
| break; |
There was a problem hiding this comment.
nit: parameterised logging.
| @@ -178,6 +178,8 @@ public class BucketCache implements BlockCache, HeapSize { | |||
|
|
|||
| private final BucketCacheStats cacheStats = new BucketCacheStats(); | |||
|
|
|||
| /** BucketCache persister thread */ | |||
| BucketCachePersister cachePersister; | |||
There was a problem hiding this comment.
nit: should be private?
| final java.nio.file.Path mapFile = | ||
| FileSystems.getDefault().getPath(testDir.toString(), "bucket.persistence"); | ||
| assertTrue(Files.deleteIfExists(mapFile)); | ||
| Thread.sleep(1500); |
There was a problem hiding this comment.
Could we expedite this test by reducing the configured bucketcachePersistInterval to 100ms only? Then we could reduce this sleep to a lower value too, say 150ms.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
May 12, 2023
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…ucketCache is shutdown (apache#5230) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit e343584) Change-Id: I732be093d06cedecd607b83fea00d5306cabeee8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s shutdown
Jira: https://issues.apache.org/jira/browse/HBASE-27852