HBASE-28716: Users of QuotaRetriever should pass an existing connection (master) #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
unit test failure appears unrelated |
ndimiduk
requested changes
Jul 17, 2024
There was a problem hiding this comment.
I think this kind of change is the correct thing to do. In principal, our non-service classes should never manage their own Connection instances and instead rely on a caller to provide one. However, we need to execute this change according to our deprecation policy.
| * Should QutoaRetriever manage the state of the connection, or leave it be. | ||
| */ | ||
| private boolean isManagedConnection = false; | ||
|
|
||
| QuotaRetriever() { |
There was a problem hiding this comment.
What a weird API. This class is decorated as IA.Public but it's only created via these static factory method? Any what's with using the default constructor + an init method -- what happened to RAII ?’
There was a problem hiding this comment.
Are non-public methods of an IA.Public class required to go through a deprecation cycle, or only public methods?
There was a problem hiding this comment.
Okay, then this PR is complying with the deprecation policy now
| * @return the QuotaRetriever | ||
| * @throws IOException if a remote or network exception occurs | ||
| */ | ||
| public static QuotaRetriever open(final Configuration conf) throws IOException { | ||
| return open(conf, null); | ||
| public static QuotaRetriever open(final Connection conn) throws IOException { |
There was a problem hiding this comment.
Because this is IA.Public, you cannot make these blanket changes in one pass. You'll need to observe a deprecation cycle through a major release in order to make breaking changes to the public API.
We document this in depth over on https://hbase.apache.org/book.html#hbase.versioning
If we're going through the trouble to make breaking changes, let's push RAII and do away with the parameterless constructor + init method.
There was a problem hiding this comment.
+1 for the deprecation cycle.
There was a problem hiding this comment.
If we're going through the trouble to make breaking changes, let's push RAII and do away with the parameterless constructor + init method.
Since we're opening this worm-can, how about we get rid of these static constructor methods and use constructors like a normal object?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ndimiduk
requested changes
Jul 18, 2024
| * @return the QuotaRetriever | ||
| * @throws IOException if a remote or network exception occurs | ||
| */ | ||
| public static QuotaRetriever open(final Configuration conf) throws IOException { | ||
| return open(conf, null); | ||
| public static QuotaRetriever open(final Connection conn) throws IOException { |
There was a problem hiding this comment.
If we're going through the trouble to make breaking changes, let's push RAII and do away with the parameterless constructor + init method.
Since we're opening this worm-can, how about we get rid of these static constructor methods and use constructors like a normal object?
| @@ -168,7 +168,7 @@ Multimap<TableName, String> getSnapshotsToComputeSize() throws IOException { | |||
| filter.addTypeFilter(QuotaType.SPACE); | |||
| try (Admin admin = conn.getAdmin()) { | |||
| // Pull all of the tables that have quotas (direct, or from namespace) | |||
| for (QuotaSettings qs : QuotaRetriever.open(conf, filter)) { | |||
| for (QuotaSettings qs : QuotaRetriever.open(conn, filter)) { | |||
There was a problem hiding this comment.
Would you mind also promoting uses of the QuotaRetriever object up to try-with-resource blocks? In this particular case, it looks like we never close the object.
There was a problem hiding this comment.
Yep, you got it!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Unit test failure looks unrelated |
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 19, 2024
apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 19, 2024
apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 19, 2024
apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 19, 2024
apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
ndimiduk
pushed a commit
that referenced
this pull request
Jul 22, 2024
#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
ndimiduk
added a commit
that referenced
this pull request
Jul 23, 2024
#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 23, 2024
apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Jul 23, 2024
apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>
ndimiduk
added a commit
that referenced
this pull request
Jul 24, 2024
#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>
ndimiduk
added a commit
that referenced
this pull request
Jul 24, 2024
#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>
charlesconnell
added a commit
to HubSpot/hbase
that referenced
this pull request
Jul 24, 2024
apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> Co-authored-by: Charles Connell <cconnell@hubspot.com>
charlesconnell
added a commit
to HubSpot/hbase
that referenced
this pull request
Jul 24, 2024
apache#6065) (#107) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every call to
HBaseAdmin#getQuota()opens a newConnection, and then closes it. As far as I can tell, this is pointless, since it could use the existingConnectionobject held by theHBaseAdmin. Change this and other uses of QuotaRetriever to use existing Connections.