HBASE-29317 Bump hbase-thirdparty to 4.1.11 (#6993) #7043

NihalJain · 2025-05-27T18:04:12Z

Update allowed_expr to allow org/jspecify/annotation/*.class which is coming from guava due to google/guava@2cc8c5e
Bump maven-shade-plugin to 3.6.0 as we see failure META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66 due to FasterXML/jackson-core@7d8dc09
Add --should-stop=ifError=FLOW as compilerArgs. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches.
Error Prone 2.31.0 is the latest version which supports running on JDK 11

…allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details!

…JDK 11

taklwu · 2025-05-28T18:41:54Z

hbase-build-configuration/pom.xml

                <arg>-XDcompilePolicy=simple</arg>
                <!-- All -Xep need to be on single line see: https://github.com/google/error-prone/pull/1115 -->
                <arg>-Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode -XepExcludedPaths:.*/target/.* -Xep:FallThrough:OFF -Xep:MutablePublicArray:OFF -Xep:ClassNewInstance:ERROR -Xep:MissingDefault:ERROR -Xep:BanJNDI:WARN</arg>
+                <!-- Required by error prone >= 2.36.0. See https://github.com/google/error-prone/commit/e71db1f369a9367f6f2db34c4fbd006b6d6238fd !-->


nit: is the 2.36.0 the same as error-prone.version ? if not , where does it come from ?

Yes @taklwu you are right. We actually move to 2.36.0 but since branch 2 still uses jdk11 for error prone we downgraded. We did not remove these to keep code as much in sync with master and having this did not have any adverse effect. Current this line should be a no op for the versiom of error prone we are on, in branch-2.

Apache-HBase · 2025-06-01T17:53:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s		branch-2.6 passed
+1 💚	compile	6m 6s		branch-2.6 passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 6s		the patch passed
+1 💚	compile	5m 58s		the patch passed
-0 ⚠️	javac	5m 58s	/results-compile-javac-root.txt	root generated 13 new + 1257 unchanged - 1 fixed = 1270 total (was 1258)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	16m 53s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		40m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7043
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile shellcheck shelldocs
uname	Linux b597fb42a37c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `5987c2f`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/console
versions	git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-06-01T21:53:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 34s		branch-2.6 passed
+1 💚	compile	2m 16s		branch-2.6 passed
+1 💚	javadoc	2m 23s		branch-2.6 passed
+1 💚	shadedjars	6m 20s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	2m 13s		the patch passed
+1 💚	javac	2m 13s		the patch passed
+1 💚	javadoc	2m 23s		the patch passed
+1 💚	shadedjars	6m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	244m 51s	/patch-unit-root.txt	root in the patch failed.
		281m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7043
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 97d268ed41da 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `5987c2f`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/testReport/
Max. process+thread count	8257 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-06-01T22:38:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s		branch-2.6 passed
+1 💚	compile	2m 12s		branch-2.6 passed
+1 💚	javadoc	2m 36s		branch-2.6 passed
+1 💚	shadedjars	6m 43s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 11s		the patch passed
+1 💚	compile	2m 12s		the patch passed
+1 💚	javac	2m 12s		the patch passed
+1 💚	javadoc	2m 24s		the patch passed
+1 💚	shadedjars	6m 38s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	280m 1s	/patch-unit-root.txt	root in the patch failed.
		326m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7043
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c1ee5ee57cd7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `5987c2f`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/testReport/
Max. process+thread count	8272 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-06-01T23:53:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s		branch-2.6 passed
+1 💚	compile	1m 48s		branch-2.6 passed
+1 💚	javadoc	2m 8s		branch-2.6 passed
+1 💚	shadedjars	5m 33s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 27s		the patch passed
+1 💚	compile	1m 49s		the patch passed
+1 💚	javac	1m 49s		the patch passed
+1 💚	javadoc	2m 9s		the patch passed
+1 💚	shadedjars	5m 30s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	368m 28s	/patch-unit-root.txt	root in the patch failed.
		401m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7043
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d8be30ebb61c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `5987c2f`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/testReport/
Max. process+thread count	7467 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7043/9/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

stoty

+1 LGTM

NihalJain · 2025-06-02T05:47:06Z

Thank you @stoty for the review. Failures are random and unrelated, will merge this in another 2 hours!

* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>

NihalJain added 3 commits May 27, 2025 23:31

* Error Prone 2.31.0 is the latest version which supports running on …

a29f047

…JDK 11

Update to use RC1 jars

4178628

This comment has been minimized.

Sign in to view

taklwu reviewed May 28, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Drop staging repo

5987c2f

This comment has been minimized.

Sign in to view

NihalJain requested a review from taklwu May 31, 2025 12:55

This comment has been minimized.

Sign in to view

stoty approved these changes Jun 2, 2025

View reviewed changes

NihalJain merged commit b52961a into apache:branch-2.6 Jun 2, 2025
1 check failed

HBASE-29317 Bump hbase-thirdparty to 4.1.11 (#6993) #7043

HBASE-29317 Bump hbase-thirdparty to 4.1.11 (#6993) #7043

Conversation

NihalJain commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

taklwu May 28, 2025

Choose a reason for hiding this comment

Uh oh!

NihalJain May 29, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Jun 1, 2025

Uh oh!

Apache-HBase commented Jun 1, 2025

Uh oh!

Apache-HBase commented Jun 1, 2025

Uh oh!

Apache-HBase commented Jun 1, 2025

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

NihalJain commented Jun 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NihalJain commented May 27, 2025 •

edited

Loading