-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29317 Bump hbase-thirdparty to 4.1.11 #6993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR consumes apache/hbase-thirdparty#137 to check for any regression |
...shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Ran one of failing test locally, no issue. Re-triggered the job! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Ah protobuf change was missing, re-run with https://repository.apache.org/content/repositories/snapshots/org/apache/hbase/thirdparty/hbase-thirdparty/4.1.11-SNAPSHOT/hbase-thirdparty-4.1.11-20250516.182246-5.pom |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09
… error prone >= 2.36.0. See google/error-prone@e71db1f
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Failures are not related! |
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
stoty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
|
Thank you @stoty for the review, I will merge this in next 2 hours. |
* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>
* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>
* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>
* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 899e4fc)
* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>
* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>
* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>
org/jspecify/annotation/*.classwhich is coming from guava due to google/guava@2cc8c5eMETA-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66due to FasterXML/jackson-core@7d8dc09--should-stop=ifError=FLOWascompilerArgs. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details!