HBASE-29303 [hbase-thirdparty] Bump protobuf java to 4.30.2 #136

NihalJain · 2025-05-14T08:09:35Z

Handle changes required due to protocolbuffers/protobuf@a4d4bfe in HBASE-15789_V3.patch
Also rename HBASE-15789_V3.patch to HBASE-15789_V4.patch

NihalJain · 2025-05-14T08:11:56Z

Compilation will fail as variable recursionDepth no longer exists in protobuf and was removed with commit protocolbuffers/protobuf@a4d4bfe

I will try to modify the existing patch https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-protobuf/src/main/patches/HBASE-15789_V3.patch which requires this field!

NihalJain · 2025-05-14T08:19:53Z

Compilation will fail as variable recursionDepth no longer exists in protobug and was removed with commit protocolbuffers/protobuf@a4d4bfe

I will try to modify the existing patch https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-protobuf/src/main/patches/HBASE-15789_V3.patch which requires this field!

Second commit handles this issue!

Apache-HBase · 2025-05-14T08:20:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	0m 44s	master passed
+1 💚	compile	0m 24s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 6s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 10s	hbase-shaded-protobuf in the patch failed.
-1 ❌	mvninstall	0m 32s	root in the patch failed.
-1 ❌	compile	0m 10s	hbase-shaded-protobuf in the patch failed.
-1 ❌	compile	0m 9s	root in the patch failed.
-1 ❌	javac	0m 10s	hbase-shaded-protobuf in the patch failed.
-1 ❌	javac	0m 9s	root in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 9s	hbase-shaded-protobuf in the patch failed.
-1 ❌	unit	0m 48s	root in the patch failed.
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		5m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#136
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 2dd4a20abbd5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
git revision	master / `6016e75`
Default Java	Temurin-1.8.0_452-b09
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javac	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
unit	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt
unit	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/testReport/
Max. process+thread count	398 (vs. ulimit of 1000)
modules	C: hbase-shaded-protobuf . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/console
versions	git=2.43.0 maven=3.9.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-05-14T08:20:38Z

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 0m 44s master passed
+1 💚 compile 0m 24s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 10s hbase-shaded-protobuf in the patch failed.
-1 ❌ mvninstall 0m 32s root in the patch failed.
-1 ❌ compile 0m 10s hbase-shaded-protobuf in the patch failed.
-1 ❌ compile 0m 9s root in the patch failed.
-1 ❌ javac 0m 10s hbase-shaded-protobuf in the patch failed.
-1 ❌ javac 0m 9s root in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
-1 ❌ unit 0m 9s hbase-shaded-protobuf in the patch failed.
-1 ❌ unit 0m 48s root in the patch failed.
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
5m 26s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #136
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 2dd4a20abbd5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / 6016e75
Default Java Temurin-1.8.0_452-b09
mvninstall https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt
mvninstall https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
compile https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javac https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
unit https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt
unit https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/testReport/
Max. process+thread count 398 (vs. ulimit of 1000)
modules C: hbase-shaded-protobuf . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/console
versions git=2.43.0 maven=3.9.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org
This message was automatically generated.

Failed, as expected!

stoty · 2025-05-14T08:39:39Z

Is the protobuf fork we're generating the patch from available somewhere ( i.e. github.com )?

NihalJain · 2025-05-14T08:50:12Z

Is the protobuf fork we're generating the patch from available somewhere ( i.e. github.com )?

Yes please refer README.md of thirdparty repo. I added steps to generate patch from protobuf clone during last release.

For this PR, I checked out v30.2.

Apache-HBase · 2025-05-14T08:58:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 5s	Maven dependency ordering for branch
+1 💚	mvninstall	0m 36s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 5s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 5s	hbase-shaded-protobuf in the patch failed.
-1 ❌	mvninstall	0m 29s	root in the patch failed.
-1 ❌	compile	0m 6s	hbase-shaded-protobuf in the patch failed.
-1 ❌	compile	0m 6s	root in the patch failed.
-1 ❌	javac	0m 6s	hbase-shaded-protobuf in the patch failed.
-1 ❌	javac	0m 6s	root in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 5s	hbase-shaded-protobuf in the patch failed.
-1 ❌	unit	0m 41s	root in the patch failed.
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		3m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#136
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux bb6a94748441 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
git revision	master / `6016e75`
Default Java	Temurin-1.8.0_452-b09
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javac	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-compile-root.txt
unit	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt
unit	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/testReport/
Max. process+thread count	395 (vs. ulimit of 1000)
modules	C: hbase-shaded-protobuf . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/console
versions	git=2.43.0 maven=3.9.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-05-14T08:59:43Z

Strange even though I have renamed the patch file it is still applying old one not sure how.

[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789_V3.patch
[INFO] Applying patch: HBASE-15789_V4.patch

Ref https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt

hbase-shaded-protobuf/pom.xml

Apache-HBase · 2025-05-15T14:50:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 5s	Maven dependency ordering for branch
+1 💚	mvninstall	0m 37s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	javadoc	0m 13s	master passed
-0 ⚠️	patch	1m 27s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 5s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 56s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 18s	hbase-shaded-protobuf in the patch passed.
+1 💚	unit	1m 6s	root in the patch passed.
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		5m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/9/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#136
Optional Tests	dupname asflicense javac javadoc unit xml compile markdownlint
uname	Linux 3c9c65d9fa11 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
git revision	master / `6016e75`
Default Java	Temurin-1.8.0_452-b09
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/9/testReport/
Max. process+thread count	395 (vs. ulimit of 1000)
modules	C: hbase-shaded-protobuf . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/9/console
versions	git=2.43.0 maven=3.9.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-05-15T14:51:51Z

Finally a Pass 😌

[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789_V4.patch
[INFO] Applying patch: HBASE-17087.patch
[INFO] Applying patch: HBASE-17239.patch

Hi @stoty , @Apache9 does this look good? Should I go ahead run this PR and #135 against hbase master branch?

stoty · 2025-05-16T04:44:57Z

README.md


 ```
-HBASE-15789_V3.patch
+HBASE-15789_V4.patch


nit: not sure versioning this patch is useful.

Raised https://issues.apache.org/jira/browse/HBASE-29343

stoty

+1 LGTM

stoty · 2025-05-16T04:46:48Z

Sure, running a full CI build is the only way to validate.

NihalJain · 2025-05-17T04:25:49Z

Sure, running a full CI build is the only way to validate.

Build passes with this change, refer apache/hbase#6993

Apache-HBase · 2025-05-19T23:49:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 1s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
-1 ❌	mvninstall	0m 17s	root in master failed.
-1 ❌	compile	0m 17s	root in master failed.
-1 ❌	compile	0m 18s	hbase-shaded-protobuf in master failed.
-1 ❌	javadoc	0m 17s	root in master failed.
-1 ❌	javadoc	0m 18s	hbase-shaded-protobuf in master failed.
-0 ⚠️	patch	2m 32s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 18s	root in the patch failed.
-1 ❌	mvninstall	0m 17s	hbase-shaded-protobuf in the patch failed.
-1 ❌	compile	0m 17s	root in the patch failed.
-1 ❌	compile	0m 18s	hbase-shaded-protobuf in the patch failed.
-1 ❌	javac	0m 17s	root in the patch failed.
-1 ❌	javac	0m 18s	hbase-shaded-protobuf in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
-1 ❌	javadoc	0m 17s	root in the patch failed.
-1 ❌	javadoc	0m 17s	hbase-shaded-protobuf in the patch failed.
		_ Other Tests _
-1 ❌	unit	0m 17s	root in the patch failed.
-1 ❌	unit	0m 17s	hbase-shaded-protobuf in the patch failed.
+0 🆗	asflicense	0m 34s	ASF License check generated no output?
		8m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#136
Optional Tests	dupname asflicense javac javadoc unit xml compile markdownlint
uname	Linux add74a049221 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
git revision	master / `6016e75`
Default Java	Temurin-1.8.0_452-b09
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-compile-root.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-protobuf.txt
javadoc	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-javadoc-root.txt
javadoc	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-protobuf.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-compile-root.txt
compile	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javac	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javadoc	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-javadoc-root.txt
javadoc	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt
unit	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-unit-root.txt
unit	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/testReport/
Max. process+thread count	20 (vs. ulimit of 1000)
modules	C: . hbase-shaded-protobuf U: .
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/console
versions	git=2.43.0 maven=3.9.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-20T07:35:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 1s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	0m 43s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	javadoc	0m 13s	master passed
-0 ⚠️	patch	1m 47s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 6s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 52s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 11s	hbase-shaded-protobuf in the patch passed.
+1 💚	unit	0m 47s	root in the patch passed.
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		5m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/11/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#136
Optional Tests	dupname asflicense javac javadoc unit xml compile markdownlint
uname	Linux 675b136a2947 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
git revision	master / `6016e75`
Default Java	Temurin-1.8.0_452-b09
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/11/testReport/
Max. process+thread count	383 (vs. ulimit of 1000)
modules	C: hbase-shaded-protobuf . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/11/console
versions	git=2.43.0 maven=3.9.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk

This patch management is so tedious.

…d4bfe in HBASE-15789_V3.patch * Also rename HBASE-15789_V3.patch to HBASE-15789_V4.patch

Apache-HBase · 2025-05-20T16:50:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 0s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	0m 45s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	javadoc	0m 12s	master passed
-0 ⚠️	patch	1m 44s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 6s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 52s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 10s	hbase-shaded-protobuf in the patch passed.
+1 💚	unit	0m 48s	root in the patch passed.
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		5m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/12/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#136
Optional Tests	dupname asflicense javac javadoc unit xml compile markdownlint
uname	Linux 8e75e723741c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
git revision	master / `848f4b3`
Default Java	Temurin-1.8.0_452-b09
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/12/testReport/
Max. process+thread count	397 (vs. ulimit of 1000)
modules	C: hbase-shaded-protobuf . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/12/console
versions	git=2.43.0 maven=3.9.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-05-20T16:54:45Z

This patch management is so tedious.

Yes, it really is. Let me raise a JIRA to at least change the requirement to rename a patch as @stoty also suggested seems to be not much useful.

NihalJain marked this pull request as draft May 14, 2025 08:09

NihalJain requested review from Apache9, pankaj72981 and stoty May 14, 2025 08:18

NihalJain marked this pull request as ready for review May 14, 2025 08:18

NihalJain requested a review from ndimiduk May 14, 2025 08:22

This comment was marked as outdated.

Sign in to view

NihalJain commented May 14, 2025

View reviewed changes

hbase-shaded-protobuf/pom.xml Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

NihalJain force-pushed the HBASE-29303 branch from ba09ddd to e012f56 Compare May 14, 2025 13:01

This comment was marked as outdated.

Sign in to view

NihalJain mentioned this pull request May 15, 2025

[Do Not Merge] Test PR for v4.1.11 #137

Closed

stoty reviewed May 16, 2025

View reviewed changes

stoty approved these changes May 16, 2025

View reviewed changes

mnpoonia approved these changes May 19, 2025

View reviewed changes

ndimiduk approved these changes May 20, 2025

View reviewed changes

NihalJain added 4 commits May 20, 2025 22:07

HBASE-29303 [hbase-thirdparty] Bump protobuf java to 4.30.2

0c28eea

* Make changes (manually) required due to protocolbuffers/protobuf@a4…

0484ca6

…d4bfe in HBASE-15789_V3.patch * Also rename HBASE-15789_V3.patch to HBASE-15789_V4.patch

* Revert back filename to V3 as build fails otherwise

5c66bd2

* Gitignore should not ignore patches folder

fb4ac29

NihalJain force-pushed the HBASE-29303 branch from f142475 to fb4ac29 Compare May 20, 2025 16:38

NihalJain merged commit ad09819 into apache:master May 20, 2025
1 check passed

HBASE-29303 [hbase-thirdparty] Bump protobuf java to 4.30.2 #136

HBASE-29303 [hbase-thirdparty] Bump protobuf java to 4.30.2 #136

Uh oh!

Conversation

NihalJain commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NihalJain commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NihalJain commented May 14, 2025

Uh oh!

Apache-HBase commented May 14, 2025

Uh oh!

NihalJain commented May 14, 2025

Uh oh!

This comment was marked as outdated.

stoty commented May 14, 2025

Uh oh!

NihalJain commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented May 14, 2025

Uh oh!

NihalJain commented May 14, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented May 15, 2025

Uh oh!

NihalJain commented May 15, 2025

Uh oh!

stoty May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NihalJain May 20, 2025

Choose a reason for hiding this comment

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

stoty commented May 16, 2025

Uh oh!

NihalJain commented May 17, 2025

Uh oh!

Apache-HBase commented May 19, 2025

Uh oh!

Apache-HBase commented May 20, 2025

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 20, 2025

Uh oh!

Uh oh!

NihalJain commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NihalJain commented May 14, 2025 •

edited

Loading

NihalJain commented May 14, 2025 •

edited

Loading

NihalJain commented May 14, 2025 •

edited

Loading

stoty May 16, 2025 •

edited

Loading