Skip to content

Conversation

@NihalJain
Copy link
Contributor

  • netty 4.1.119.Final -> 4.1.121.Final
  • netty.tcnative 2.0.69.Final -> 2.0.71.Final
  • guava 33.4.0-jre -> 33.4.8-jre
  • error_prone_annotations 2.36.0 -> 2.38.0
  • gson 2.11.0 -> 2.13.1
  • jetty 9.4.56.v20240826 -> 9.4.57.v20241219
  • jetty-12-plus 12.0.20 -> 12.0.21
  • jackson-jaxrs-json-provider 2.17.3 -> 2.19.0

* netty 4.1.119.Final -> 4.1.121.Final
* netty.tcnative 2.0.69.Final -> 2.0.71.Final
* guava 33.4.0-jre -> 33.4.8-jre
* error_prone_annotations 2.36.0 -> 2.38.0
* gson 2.11.0 -> 2.13.1
* jetty 9.4.56.v20240826 -> 9.4.57.v20241219
* jetty-12-plus 12.0.20 -> 12.0.21
* jackson-jaxrs-json-provider 2.17.3 -> 2.19.0
@NihalJain NihalJain requested review from Apache9, ndimiduk and stoty May 14, 2025 06:16
@stoty
Copy link
Contributor

stoty commented May 14, 2025

Do you have an HBase test run with these versions ?
Otherwise LGTM.

@NihalJain
Copy link
Contributor Author

NihalJain commented May 14, 2025

Do you have an HBase test run with these versions ? Otherwise LGTM.

Yes I plan to run. Will create a commit with both proto and this change clubbed together and push snapshot and run hbase tests with that. Working on proto change right now. Will update once done!

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 0m 50s master passed
+1 💚 compile 0m 13s master passed
+1 💚 javadoc 0m 7s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 40s the patch passed
+1 💚 compile 0m 13s the patch passed
+1 💚 javac 0m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 0s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 45s root in the patch passed.
+1 💚 asflicense 0m 7s The patch does not generate ASF License warnings.
3m 36s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-135/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #135
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux b46885311232 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / 6016e75
Default Java Temurin-1.8.0_452-b09
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-135/2/testReport/
Max. process+thread count 388 (vs. ulimit of 1000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-135/2/console
versions git=2.43.0 maven=3.9.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
Copy link
Contributor Author

Do you have an HBase test run with these versions ? Otherwise LGTM.

Yes I plan to run. Will create a commit with both proto and this change clubbed together and push snapshot and run hbase tests with that. Working on proto change right now. Will update once done!

Build passes with this change, refer apache/hbase#6993, please let me know if we are good to merge this

Copy link

@mnpoonia mnpoonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something i was looking at as have updated at my day job few days ago.

@NihalJain NihalJain merged commit 848f4b3 into apache:master May 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants