-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-23196 The IndexChunkPool’s percentage is hard code to 0.1 #757
Conversation
Can you help to review this? @anoopsjohn @openinx @ramkrish86 |
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Show resolved
Hide resolved
Optional<MemStoreChunkPool> pool = | ||
size == this.indexChunkSize ? indexChunksPool : dataChunksPool; | ||
Chunk chunk = pool.map(MemStoreChunkPool::getChunk).orElseGet( | ||
new Supplier<Chunk>() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
Let me fix TestCompactingToCellFlatMapMemStore, other failed UT seems unrelated |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
1 similar comment
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Any updates here? |
Closing. No updates. |
No description provided.