Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move extending part to sqlparser #155

Closed
Rachelint opened this issue Jul 28, 2022 · 2 comments
Closed

refactor: move extending part to sqlparser #155

Rachelint opened this issue Jul 28, 2022 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@Rachelint
Copy link
Contributor

Description

Now, the method of extending sqlparser in ceresdb is too rough. We copy tons of codes from sqlparser and it's a kind of hard-fork in fact. So as I think, forking sqlparser and moving the extending part to it may be better.

Proposal

  • Moving 'Statement' used in ceresdb to sqlparser.
  • Add related keywords.
  • Add related branch in parse_statement().

Additional context

@Rachelint Rachelint added the feature New feature or request label Jul 28, 2022
@Rachelint Rachelint self-assigned this Jul 28, 2022
@waynexia
Copy link
Member

@dust1 @waynexia I intend to refactor as #155 temporarily.
But I think it's still no so good.
-- from #154 (comment)

Yep... The burden of maintaining the parser part still exists.

@Rachelint
Copy link
Contributor Author

@dust1 @waynexia I intend to refactor as #155 temporarily.
But I think it's still no so good.
-- from #154 (comment)

Yep... The burden of maintaining the parser part still exists.

The functions(such as parse_columns, parse_optional_column_option, etc) are customized in ceresdb and conflicts with those in sqlparser. It seems not so suitable to move them to sqlparser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants