Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad name in ReadableSize #428

Closed
jiacai2050 opened this issue Nov 28, 2022 · 0 comments · Fixed by #767
Closed

Bad name in ReadableSize #428

jiacai2050 opened this issue Nov 28, 2022 · 0 comments · Fixed by #767
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Nov 28, 2022

Describe this problem

https://github.com/CeresDB/ceresdb/blob/659b55985a14f835cff5bbb2df4eea1b0a540366/common_util/src/config.rs#L149

In ReadableSize, there is a method called as_bytes(), which is very confusing, since the original meaning of as_bytes is to return &[u8], not u64

Steps to reproduce

No required.

Expected behavior

No response

Additional Information

I suggest we name it as_byte to follow other methods in ReadableSize

@jiacai2050 jiacai2050 added the bug Something isn't working label Nov 28, 2022
@ShiKaiWi ShiKaiWi added the good first issue Good for newcomers label Dec 8, 2022
ShiKaiWi pushed a commit that referenced this issue Mar 26, 2023
* fix: rename as_bytes to as_byte in ReadableSize (#428)

* style: fmt server.rs
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this issue May 15, 2023
)

* fix: rename as_bytes to as_byte in ReadableSize (apache#428)

* style: fmt server.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
2 participants