We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/CeresDB/ceresdb/blob/659b55985a14f835cff5bbb2df4eea1b0a540366/common_util/src/config.rs#L149
In ReadableSize, there is a method called as_bytes(), which is very confusing, since the original meaning of as_bytes is to return &[u8], not u64
ReadableSize
as_bytes()
as_bytes
&[u8]
u64
No required.
No response
I suggest we name it as_byte to follow other methods in ReadableSize
as_byte
The text was updated successfully, but these errors were encountered:
fix: rename as_bytes to as_byte in ReadableSize (#428) (#767)
b2c24d8
* fix: rename as_bytes to as_byte in ReadableSize (#428) * style: fmt server.rs
fix: rename as_bytes to as_byte in ReadableSize (apache#428) (apache#767
15b365b
) * fix: rename as_bytes to as_byte in ReadableSize (apache#428) * style: fmt server.rs
Successfully merging a pull request may close this issue.
Describe this problem
https://github.com/CeresDB/ceresdb/blob/659b55985a14f835cff5bbb2df4eea1b0a540366/common_util/src/config.rs#L149
In
ReadableSize
, there is a method calledas_bytes()
, which is very confusing, since the original meaning ofas_bytes
is to return&[u8]
, notu64
Steps to reproduce
No required.
Expected behavior
No response
Additional Information
I suggest we name it
as_byte
to follow other methods in ReadableSizeThe text was updated successfully, but these errors were encountered: