Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename as_bytes to as_byte in ReadableSize (#428) #767

Merged
merged 2 commits into from
Mar 26, 2023
Merged

fix: rename as_bytes to as_byte in ReadableSize (#428) #767

merged 2 commits into from
Mar 26, 2023

Conversation

zouxiang1993
Copy link
Contributor

Which issue does this PR close?

Closes #428

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

How does this change test

@ShiKaiWi
Copy link
Member

@zouxiang1993 Thanks for your contribution. It looks pretty and will be merged when the status check finishes.

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Merging #767 (8ba61e6) into main (8a9635e) will decrease coverage by 0.03%.
The diff coverage is 24.32%.

❗ Current head 8ba61e6 differs from pull request most recent head 5b73001. Consider uploading reports for the commit 5b73001 to get more accurate results

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   68.34%   68.32%   -0.03%     
==========================================
  Files         296      296              
  Lines       46315    46318       +3     
==========================================
- Hits        31656    31647       -9     
- Misses      14659    14671      +12     
Impacted Files Coverage Δ
server/src/server.rs 0.00% <0.00%> (ø)
analytic_engine/src/setup.rs 56.00% <40.00%> (ø)
analytic_engine/src/compaction/picker.rs 84.44% <50.00%> (ø)
analytic_engine/src/compaction/scheduler.rs 74.41% <100.00%> (ø)
analytic_engine/src/instance/open.rs 80.74% <100.00%> (ø)
common_util/src/config.rs 87.02% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 26, 2023
Merged via the queue into apache:main with commit b2c24d8 Mar 26, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
)

* fix: rename as_bytes to as_byte in ReadableSize (apache#428)

* style: fmt server.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad name in ReadableSize
4 participants