-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simplify SQL syntax that specifies timestamp key column #140
Conversation
We now have integration test suite for this kind of changes. Would you like to add this new syntax to it? Maybe some new SQLs in https://github.com/CeresDB/ceresdb/blob/main/tests/cases/local/05_ddl/create_tables.sql 🤗 |
sure! not adding test cases is my mistake😂 |
Not your fault! This is newly added. I'll add it to our dev guide |
@dust1 Thanks. It looks much better but I guess it can be made more simple. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dust1 Now it looks clean and pretty. And now maybe we should pay some attention to user's wrong use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…#140) * Simplify SQL syntax that specifies timestamp key column * Typo: Ceres * use ColumnOption::DialectSpecific * simplicity of the parse_columns. * not allowed define mutiple tskey constraints.
Which issue does this PR close?
Closes #115
ref #154
Rationale for this change
What changes are included in this PR?
I added 3 structs just to transmit the
is_timestamp
tag.in
ast.rs
Are there any user-facing changes?
now, user can use this sql to create table.
How does this change test
note