Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl remote_engine grpc service #508

Merged
merged 8 commits into from
Dec 27, 2022
Merged

feat: impl remote_engine grpc service #508

merged 8 commits into from
Dec 27, 2022

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Dec 25, 2022

Which issue does this PR close?

Closes #
Part of #492

Rationale for this change

Implement remote_engine grpc service based on #505.

What changes are included in this PR?

  • Implement remote_engine grpc service.
  • Serialize rows with avro.
  • Move ProjectedSchema to common.proto.

Are there any user-facing changes?

No.

How does this change test

@chunshao90 chunshao90 marked this pull request as ready for review December 26, 2022 08:05
@chunshao90 chunshao90 mentioned this pull request Dec 26, 2022
7 tasks
common_util/src/avro.rs Outdated Show resolved Hide resolved
common_util/src/avro.rs Show resolved Hide resolved
common_util/src/avro.rs Outdated Show resolved Hide resolved
common_util/src/avro.rs Outdated Show resolved Hide resolved
common_util/src/avro.rs Outdated Show resolved Hide resolved
common_util/src/avro.rs Outdated Show resolved Hide resolved
proto/protos/remote_engine.proto Outdated Show resolved Hide resolved
table_engine/src/predicate.rs Outdated Show resolved Hide resolved
table_engine/src/remote/mod.rs Outdated Show resolved Hide resolved
table_engine/src/table.rs Outdated Show resolved Hide resolved
common_util/src/avro.rs Outdated Show resolved Hide resolved
common_util/src/avro.rs Outdated Show resolved Hide resolved
common_util/src/avro.rs Outdated Show resolved Hide resolved
common_util/src/avro.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 03f5f78 into apache:main Dec 27, 2022
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: impl remote_engine grpc service

* chore: refactor code

* chore: refactor code

* refactor by CR

* refactor by CR

* make CI happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants