Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement route interface in http protocol #803

Merged
merged 13 commits into from
Apr 6, 2023
Merged

feat: implement route interface in http protocol #803

merged 13 commits into from
Apr 6, 2023

Conversation

MichaelLeeHZ
Copy link
Contributor

@MichaelLeeHZ MichaelLeeHZ commented Apr 3, 2023 •
edited by chunshao90
Loading

Which issue does this PR close?

Closes #146

Rationale for this change

See #146

What changes are included in this PR?

Add route interface in http protocol.

Are there any user-facing changes?

User can get table route information by http request, not only by Grpc.

How does this change test

@MichaelLeeHZ MichaelLeeHZ marked this pull request as ready for review April 3, 2023 09:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023 •
edited
Loading

Codecov Report

Merging #803 (33d0a7b) into main (0831a84) will decrease coverage by 0.11%.
The diff coverage is 6.66%.

❗ Current head 33d0a7b differs from pull request most recent head 472d54a. Consider uploading reports for the commit 472d54a to get more accurate results

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   68.18%   68.07%   -0.11%     
==========================================
  Files         295      296       +1     
  Lines       46880    46893      +13     
==========================================
- Hits        31963    31924      -39     
- Misses      14917    14969      +52
Impacted Files Coverage Δ
analytic_engine/src/instance/open.rs 80.69% <ø> (-0.06%) ⬇️
analytic_engine/src/manifest/details.rs 95.63% <ø> (-0.03%) ⬇️
catalog/src/schema.rs 78.26% <ø> (-0.91%) ⬇️
catalog_impls/src/table_based.rs 83.43% <ø> (-0.03%) ⬇️
...nterpreters/src/table_manipulator/catalog_based.rs 98.13% <ø> (-0.02%) ⬇️
server/src/context.rs 0.00% <0.00%> (ø)
server/src/grpc/meta_event_service/mod.rs 0.00% <ø> (ø)
server/src/handlers/error.rs 0.00% <ø> (ø)
server/src/handlers/route.rs 0.00% <0.00%> (ø)
server/src/http.rs 0.00% <0.00%> (ø)
... and 4 more

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ShiKaiWi
ShiKaiWi reviewed Apr 3, 2023
View reviewed changes
server/src/context.rs Outdated Show resolved Hide resolved
server/src/handlers/route.rs Outdated Show resolved Hide resolved
chunshao90
chunshao90 reviewed Apr 3, 2023
View reviewed changes
server/src/server.rs Outdated Show resolved Hide resolved
server/src/server.rs Outdated Show resolved Hide resolved
server/src/handlers/route.rs Outdated Show resolved Hide resolved
server/src/handlers/route.rs Outdated Show resolved Hide resolved
server/src/http.rs Show resolved Hide resolved
MichaelLeeHZ and others added 3 commits April 3, 2023 18:09
ShiKaiWi
ShiKaiWi approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Apr 6, 2023
Merged via the queue into apache:main with commit 6e4fe92 Apr 6, 2023
@jiacai2050 jiacai2050 mentioned this pull request Apr 6, 2023
Merged
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@MichaelLeeHZ @ShiKaiWi
feat: implement route interface in http protocol (apache#803)
e685625 
* http route

* debug

* add http route interface

* fmt

* http router

* fmt

* Update server/src/context.rs

Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>

* optimize input/output

* chore

* remove log

* clippy

---------

Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunshao90 chunshao90 chunshao90 left review comments

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement route interface in HTTP protocol
4 participants
@MichaelLeeHZ @codecov-commenter @ShiKaiWi @chunshao90