Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add router when build request context for mysql #809

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jiacai2050
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

After #803, mysql protocol is broken

2023-04-06 15:04:39.811 ERRO [server/src/mysql/worker.rs:99] MysqlWorker on_query failed. err:Failed to create request context, err:Missing router.   
Backtrace:                                                                                                                                            
 0 backtrace::backtrace::libunwind::trace::h02fd638a62f821d3                                                                                          
   /Users/jiacai/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.67/src/backtrace/libunwind.rs:93                                       
   backtrace::backtrace::trace_unsynchronized::h21f1d53b167bd280                                                                                      
   /Users/jiacai/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.67/src/backtrace/mod.rs:66                                             
 1 backtrace::backtrace::trace::h5f4a55b0f18253c1                                                                                                     
   /Users/jiacai/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.67/src/backtrace/mod.rs:53                                             
 2 backtrace::capture::Backtrace::create::h5df2d1bf7de6d59d                                                                                           
   /Users/jiacai/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.67/src/capture.rs:176                                                  
 3 backtrace::capture::Backtrace::new::h6666dcbb050e34a2 

What changes are included in this PR?

  • Add router when build request context for mysql

Are there any user-facing changes?

No

How does this change test

Add new integration tests for mysql

@codecov-commenter
Copy link

Codecov Report

Merging #809 (d0efc20) into main (f5af256) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head d0efc20 differs from pull request most recent head e717bb7. Consider uploading reports for the commit e717bb7 to get more accurate results

@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   67.86%   67.84%   -0.02%     
==========================================
  Files         295      295              
  Lines       46631    46646      +15     
==========================================
+ Hits        31648    31649       +1     
- Misses      14983    14997      +14     
Impacted Files Coverage Δ
server/src/mysql/builder.rs 0.00% <0.00%> (ø)
server/src/mysql/error.rs 0.00% <ø> (ø)
server/src/mysql/service.rs 0.00% <0.00%> (ø)
server/src/mysql/worker.rs 0.00% <0.00%> (ø)
server/src/server.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint added this pull request to the merge queue Apr 6, 2023
Merged via the queue into apache:main with commit 0dba9d8 Apr 6, 2023
@jiacai2050 jiacai2050 deleted the fix-mysql branch April 6, 2023 09:45
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants