Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement update for remove-snapshot-ref action #1598

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Implement update for remove-snapshot-ref action #1598

merged 4 commits into from
Feb 14, 2025

Conversation

grihabor
Copy link
Contributor

@grihabor grihabor commented Feb 1, 2025

Part of #1561
Closes #822

@grihabor grihabor marked this pull request as ready for review February 1, 2025 09:29
grihabor added a commit to grihabor/iceberg-python that referenced this pull request Feb 1, 2025
@grihabor
Revert changes (moved to apache#1598)
32e1e85
@grihabor grihabor mentioned this pull request Feb 1, 2025
Merged
Fokko
Fokko reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some style suggestions, but apart from that, it looks good to me 👍

@Fokko
Copy link
Contributor

Fokko commented Feb 3, 2025

Thanks for splitting this out 👍

@grihabor @Fokko
Rewrite existing_ref logic
c91378a 
Co-authored-by: Fokko Driesprong <fokko@apache.org>
@grihabor
Copy link
Contributor Author

@Fokko Thank you for review! Ready for another round

@grihabor
Copy link
Contributor Author

looks like 3.12 failed because of some flaky build:

failed to solve: process "/bin/sh -c curl --retry 5 -s -C - [https://archive.apache.org/dist/spark/spark-${SPARK_VERSION}/spark-${SPARK_VERSION}-bin-hadoop3.tgz](https://archive.apache.org/dist/spark/spark-$%7BSPARK_VERSION%7D/spark-$%7BSPARK_VERSION%7D-bin-hadoop3.tgz) -o spark-${SPARK_VERSION}-bin-hadoop3.tgz  && tar xzf spark-${SPARK_VERSION}-bin-hadoop3.tgz --directory /opt/spark --strip-components 1  && rm -rf spark-${SPARK_VERSION}-bin-hadoop3.tgz" did not complete successfully: exit code: 28

@grihabor grihabor requested a review from Fokko February 10, 2025 17:50
@kevinjqliu
Copy link
Contributor

I retrigger the test, we get intermittent failures from apache archive link

@grihabor
Copy link
Contributor Author

Thank you! It passed now

@grihabor
Copy link
Contributor Author

@kevinjqliu @Fokko Shall we merge this?

@Fokko
Copy link
Contributor

Fokko commented Feb 14, 2025

@grihabor Sorry for not following up here, thanks for adding this, let's get this in 🚀

@Fokko Fokko merged commit dd58ac1 into apache:main Feb 14, 2025
7 checks passed
@grihabor grihabor mentioned this pull request Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grihabor @Fokko @kevinjqliu