Add test to ensure every table update has corresponding _apply_table_update function
#952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
force-pushed
the
kevinjqliu/enforce-table-update-dispatch
branch
from
be27ba3 to
edf0c17
Compare
kevinjqliu
changed the title
_apply_table_update function
kevinjqliu
force-pushed
the
kevinjqliu/enforce-table-update-dispatch
branch
from
edf0c17 to
c5bcea7
Compare
|
@kevinjqliu Since these 2 prs #1598 #1561 are now in main, I believe you can now rebase and merge this one |
|
Amazing! @grihabor thanks for the ping, let me rebase this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test in to check that every
TableUpdateclass has a corresponding_apply_table_updatefunction.While looking at #864 and #950, I noticed that some TableUpdate classes do not have corresponding
_apply_table_updatefunction.I think we should enforce this in tests so that any future TableUpdate have the necessary
_apply_table_updateto process the update.