Python: Fix issue related to Pyenchant with executing linters on Apple Silicons#4818
Closed
dhruv-pratap wants to merge 4 commits intoapache:masterfrom
Closed
Python: Fix issue related to Pyenchant with executing linters on Apple Silicons#4818dhruv-pratap wants to merge 4 commits intoapache:masterfrom
dhruv-pratap wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
I actually was using an intel macbook when we fixed this (my primary workstation 😄 ). I do have an M1 so I'll try this out there to confirm I get the same issue and I'll try the solution described in this PR. |
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Contributor
|
I have an M1 macbook as well, so I can test this out too. I am still using my Intel macbook as my primary computer while working on migrating to the M1 machine, |
Contributor
|
Looks like we need to resolve this conflict now that tox has been replace by pre-commit. @Fokko is there a way to pass the |
Merged
Contributor
|
I'm going to close this since it is documentation for tox, but we've switched to using pre-commit and poetry. Thanks, @dhruv-pratap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are using an M1 Mac to run tox, there is currently an issue with pyenchant that you would run into while running
linters. This happens because python distributions installed bypyenvare in the default M1 architecture (aarch64), and can't find a compatible enchant library. As a workaround, you can follow the below steps.Install enchant with Homebrew
Set environment variable
PYENCHANT_LIBRARY_PATHto point to the installed enchant library before runningtox.export PYENCHANT_LIBRARY_PATH = /opt/homebrew/lib/libenchant-2.dylibYou can set this environment variable in your
~/.zshrcor in your IDE to avoid doing it everytime.