Merged
Conversation
For some reason pylint fell through the cracks when migrating from tox to pre-commit
Contributor
Author
|
I've removed the spellcheck because it relies on a C lib enchant that doesn't play very well with virtual-env. It can't find the binding anymore. I spend quite some time to get it to work, but no luck. Also looking at #4818 I've removed it for now since it is also not very friendly for new people to ask them to install system packages. |
samredai
reviewed
Jun 17, 2022
Contributor
samredai
left a comment
samredai
left a comment
There was a problem hiding this comment.
Needs to be rebased but otherwise LGTM
dramaticlly
approved these changes
Jun 17, 2022
Contributor
dramaticlly
left a comment
dramaticlly
left a comment
There was a problem hiding this comment.
LGTM, sad to see dictionary going away
danielcweeks
approved these changes
Jun 21, 2022
danielcweeks
approved these changes
Jun 21, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
* Python: Renable pylint For some reason pylint fell through the cracks when migrating from tox to pre-commit * Be more explicit in disabled checks
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
* Python: Renable pylint For some reason pylint fell through the cracks when migrating from tox to pre-commit * Be more explicit in disabled checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, pylint fell through the cracks when migrating from tox to pre-commit