-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow,Core,Spark: Remove functionality marked for removal in 1.4.0 #7987
Arrow,Core,Spark: Remove functionality marked for removal in 1.4.0 #7987
Conversation
65906a8
to
a09dd15
Compare
f6039f8
to
f2c9365
Compare
This needs a rebase after #7995 gets in |
f2c9365
to
e831aeb
Compare
@@ -46,6 +46,7 @@ | |||
* RewriteDataFiles#TARGET_FILE_SIZE_BYTES}. | |||
* | |||
* @deprecated since 1.3.0, will be removed in 1.4.0; use {@link SizeBasedFileRewriter} instead. | |||
* Note: This can only be removed once Spark 3.1 + 3.2 isn't using this API anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should update the Spark 3.1/3.2 usage in some other PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that would be great, but I'm not sure how feasible this is, given that we don't backport every feature to old Spark versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be a non-trivial process, which is probably not worth it.
e831aeb
to
f308eef
Compare
Looks like this includes changes from other PRs, so I'll hold off on reviewing until it's rebased. Just ping me when this is unblocked. |
Sorry I forgot to mention it, but yes this currently depends on the changes from #8099 |
f308eef
to
d3ec378
Compare
@rdblue this is ready for review now |
Thanks, @nastra! |
thanks for reviewing and merging this @aokolnychyi |
No description provided.