Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow,Core,Spark: Remove functionality marked for removal in 1.4.0 #7987

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Jul 4, 2023

No description provided.

@nastra nastra force-pushed the remove-deprecated-apis-for-1.4.0 branch 2 times, most recently from 65906a8 to a09dd15 Compare July 4, 2023 16:54
@nastra nastra force-pushed the remove-deprecated-apis-for-1.4.0 branch from f6039f8 to f2c9365 Compare July 5, 2023 12:24
@github-actions github-actions bot removed the OPENAPI label Jul 5, 2023
@nastra
Copy link
Contributor Author

nastra commented Jul 5, 2023

This needs a rebase after #7995 gets in

@nastra nastra force-pushed the remove-deprecated-apis-for-1.4.0 branch from f2c9365 to e831aeb Compare July 5, 2023 15:31
@@ -46,6 +46,7 @@
* RewriteDataFiles#TARGET_FILE_SIZE_BYTES}.
*
* @deprecated since 1.3.0, will be removed in 1.4.0; use {@link SizeBasedFileRewriter} instead.
* Note: This can only be removed once Spark 3.1 + 3.2 isn't using this API anymore.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should update the Spark 3.1/3.2 usage in some other PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that would be great, but I'm not sure how feasible this is, given that we don't backport every feature to old Spark versions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be a non-trivial process, which is probably not worth it.

@Fokko Fokko removed the python label Jul 13, 2023
@nastra nastra force-pushed the remove-deprecated-apis-for-1.4.0 branch from e831aeb to f308eef Compare July 19, 2023 10:29
@github-actions github-actions bot added the API label Jul 19, 2023
@rdblue
Copy link
Contributor

rdblue commented Jul 27, 2023

Looks like this includes changes from other PRs, so I'll hold off on reviewing until it's rebased. Just ping me when this is unblocked.

@nastra
Copy link
Contributor Author

nastra commented Jul 28, 2023

Sorry I forgot to mention it, but yes this currently depends on the changes from #8099

@nastra nastra force-pushed the remove-deprecated-apis-for-1.4.0 branch from f308eef to d3ec378 Compare August 1, 2023 07:11
@github-actions github-actions bot removed the API label Aug 1, 2023
@nastra
Copy link
Contributor Author

nastra commented Aug 1, 2023

@rdblue this is ready for review now

@nastra nastra added this to the Iceberg 1.4.0 milestone Aug 9, 2023
@aokolnychyi aokolnychyi merged commit 34b6058 into apache:master Aug 15, 2023
@aokolnychyi
Copy link
Contributor

Thanks, @nastra!

@nastra nastra deleted the remove-deprecated-apis-for-1.4.0 branch August 15, 2023 16:46
@nastra
Copy link
Contributor Author

nastra commented Aug 15, 2023

thanks for reviewing and merging this @aokolnychyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants