Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove deprecated classes related to rewrite data files #9296

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ajantha-bhat
Copy link
Member

@ajantha-bhat ajantha-bhat commented Dec 14, 2023

These classes were kept because it was used in Spark 3.2.
Now that the spark 3.2 is removed, we can remove these deprecated classes.

Note:
These classes were deprecated in 1.3.0. So, it can be safely removed in 1.5.0

@github-actions github-actions bot added the core label Dec 14, 2023
@ajantha-bhat ajantha-bhat marked this pull request as draft December 14, 2023 09:12
@ajantha-bhat ajantha-bhat force-pushed the core_dep branch 2 times, most recently from 1a7fade to 507fd85 Compare December 14, 2023 12:21
@github-actions github-actions bot added the spark label Dec 14, 2023
@@ -35,7 +35,7 @@
import org.apache.iceberg.SortDirection;
import org.apache.iceberg.SortOrder;
import org.apache.iceberg.Table;
import org.apache.iceberg.actions.BinPackStrategy;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #7987 forgot to handle it for Spark 3.3.

It has to be replaced with proper class now as the deprecated class is removed.

@ajantha-bhat ajantha-bhat changed the title [WIP] Core: Remove deprecated classes related to rewrite data files Core: Remove deprecated classes related to rewrite data files Dec 14, 2023
@ajantha-bhat ajantha-bhat marked this pull request as ready for review December 14, 2023 12:23
@ajantha-bhat
Copy link
Member Author

Retriggering build due to flaky test from Flink
https://github.com/apache/iceberg/actions/runs/7208855885/job/19638664888?pr=9296

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this @ajantha-bhat

@nastra
Copy link
Contributor

nastra commented Dec 14, 2023

thanks @ajantha-bhat

@nastra nastra merged commit 09290c5 into apache:main Dec 14, 2023
83 of 84 checks passed
lisirrx pushed a commit to lisirrx/iceberg that referenced this pull request Jan 4, 2024
geruh pushed a commit to geruh/iceberg that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants