-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Remove deprecated classes related to rewrite data files #9296
Conversation
1a7fade
to
507fd85
Compare
@@ -35,7 +35,7 @@ | |||
import org.apache.iceberg.SortDirection; | |||
import org.apache.iceberg.SortOrder; | |||
import org.apache.iceberg.Table; | |||
import org.apache.iceberg.actions.BinPackStrategy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like #7987 forgot to handle it for Spark 3.3.
It has to be replaced with proper class now as the deprecated class is removed.
507fd85
to
65368ce
Compare
Retriggering build due to flaky test from Flink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking care of this @ajantha-bhat
thanks @ajantha-bhat |
These classes were kept because it was used in Spark 3.2.
Now that the spark 3.2 is removed, we can remove these deprecated classes.
Note:
These classes were deprecated in 1.3.0. So, it can be safely removed in 1.5.0