Core: Fix REST catalog handling when the service has no view support #9853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcweeks
reviewed
Mar 2, 2024
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
danielcweeks
approved these changes
Mar 2, 2024
Contributor
Author
|
Okay, I can confirm that this fixes the problem locally. |
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
I'm just a bit late to this, but I also verified the behavior before/after this change in Spark. This change looks good to me.
Member
|
LGTM. How can we catch these errors early? |
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
…pache#9853) * Core: Fix REST catalog handling when the service has no view support. * Fix error message. * Improve the error message.
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
…pache#9853) * Core: Fix REST catalog handling when the service has no view support. * Fix error message. * Improve the error message.
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
…pache#9853) * Core: Fix REST catalog handling when the service has no view support. * Fix error message. * Improve the error message. (cherry picked from commit 1a4f23b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for Spark table loading when a REST catalog does not support view extensions.
The problem is that Spark runs
ResolveViewsbeforeResolveTablesin the substitution batch of rules. With view support in the REST catalog, table references will result in aloadViewcall to check if the unresolved identifier is a view. If the catalog service does not support views, then a 4XX exception is thrown but not caught and used to indicate the view does not exist.This translates 4XX calls returned by the load view path to
NoSuchViewExceptionindicating that the service does not support views.