Skip to content

Core: Fix REST catalog handling when the service has no view support #9853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2024
Merged

Core: Fix REST catalog handling when the service has no view support #9853

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5de702f
Core: Fix REST catalog handling when the service has no view support.
rdblue Mar 2, 2024
514d20e
Fix error message.
rdblue Mar 2, 2024
2a865b4
Improve the error message.
rdblue Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,12 +1058,22 @@ public List<TableIdentifier> listViews(SessionContext context, Namespace namespa
public View loadView(SessionContext context, TableIdentifier identifier) {
checkViewIdentifierIsValid(identifier);

LoadViewResponse response =
client.get(
paths.view(identifier),
LoadViewResponse.class,
headers(context),
ErrorHandlers.viewErrorHandler());
LoadViewResponse response;
try {
response =
client.get(
paths.view(identifier),
LoadViewResponse.class,
headers(context),
ErrorHandlers.viewErrorHandler());
} catch (UnsupportedOperationException | RESTException e) {
// Normally, copying an exception message is a bad practice but engines may show just the
// message and suppress the exception cause when the view does not exist. Since 401 and 403
// responses can trigger this case, including the message increases the chances that the "Not
// authorized" or "Forbidden" message is preserved and shown.
throw new NoSuchViewException(
e, "Unable to load view %s.%s: %s", name(), identifier, e.getMessage());
}

AuthSession session = tableSession(response.config(), session(context));
ViewMetadata metadata = response.metadata();
Expand Down