feat: make line bolder when line is in emphasis state, designed by #12931. #13013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
pissang
requested changes
Jul 23, 2020
|
The screenshot seems nice! I commented suggestions about the option design. Others look good to me. |
…olderWhenHover`.
pissang
requested changes
Jul 26, 2020
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
|
Is there any way to disable the feature at the moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
According to the suggested design change in #12931, add a new semantic value
bolderforemphasis.lineStyle.widthfor line series to specify whether the line should be bolder when it's in emphasis state.Fixed issues
Details
Before: What was the problem?
The line series won't be bolder to highlight when hovering on it unless users specify
emphasis.lineStyle.width.After: How is it fixed in this PR?
By default, the line series will be bolder when hovering on it. But if users set
emphasis.lineStyle.widthas a specific number manually, it will be bolder as they specified.Usage
Are there any API changes?
Added a new semantic value
bolderforemphasis.lineStyle.width, default value isbolder.Related test cases or examples to use the new APIs
Refer to
test/line-boldWhenHover.htmlOthers
Merging options
Other information