This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Make system config global (singleton as a module). #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
|
@objmagic - can you fix the travis? |
|
pretty sure Travis will fail again on integration test. Can you have a look at this PR? @taishi8117 |
|
ShuffleGrouping in the integration tests fails after 25 attempts. |
|
@objmagic I'll take a look at it |
|
@objmagic - can you resolve the conflicts and update the PR? |
objmagic
force-pushed
the
singleton-system-config
branch
from
6f40b27 to
2ca6226
Compare
|
Rebased. |
|
need more time to look into integration test failure. we can do 0.14.3 before this PR. |
|
@objmagic - is this ready to go? |
|
Yes!
|
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes system config global by putting system configuration into a single module. This corresponds to what Java instance does and we don't need to pass
sys_configaround in different initialization functions.Related to #1264.
#1309 should go first