Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Add more default metrics for Python topology #1309

Merged
merged 7 commits into from
Aug 30, 2016

Conversation

objmagic
Copy link
Contributor

@objmagic objmagic commented Aug 29, 2016

This patch adds more default metrics for Python topology, namely:

'__gateway-sent-metrics-size'
'__gateway-sent-metrics-packets-count'
'__gateway-sent-metrics-count'
'__gateway-sent-exceptions-count'
'__gateway-in-stream-queue-size'
'__gateway-out-stream-queue-size'
'__gateway-in-stream-queue-expected-capacity'
'__gateway-out-stream-queue-expected-capacity'
'__gateway-in-queue-full-count'

This PR also adds a half-acking topology example.

related to #1264

@kramasamy
Copy link
Contributor

@taishi8117 - if you could take a look at this, it will be awesome.

@kramasamy
Copy link
Contributor

it looks fine to me 👍

@kramasamy
Copy link
Contributor

let us wait until @taishi8117 gives feedback.

builder = TopologyBuilder(name=sys.argv[1])

word_spout = builder.add_spout("word_spout", WordSpout, par=2)
count_bolt = builder.add_bolt("half_ack_bolt", HalfAckBolt, par=2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change the variable name to half_ack_bolt?

@taishi8117
Copy link
Contributor

@kramasamy @objmagic I made some comments, but other than that, this PR looks fine to me.

@objmagic
Copy link
Contributor Author

@taishi8117 I have addressed your comments in the latest commit.

@objmagic
Copy link
Contributor Author

seems integration test is very unstable. restarted CI...

@kramasamy
Copy link
Contributor

Can you identify which integration test is unstable?

On Aug 30, 2016, at 10:04 AM, Mark Li notifications@github.com wrote:

seems integration test is very unstable. restarted CI...


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #1309 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAWcRF-ktaKuwqo-QKkdfSkGYCrJ9TAjks5qlGKcgaJpZM4JvL0V.

@objmagic
Copy link
Contributor Author

seems to me each one of them failed before (retried > 25 times)

@objmagic
Copy link
Contributor Author

restarted CI and now it's fine.

@objmagic objmagic merged commit 7ad1a39 into apache:master Aug 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants