-
Notifications
You must be signed in to change notification settings - Fork 594
Add more default metrics for Python topology #1309
Conversation
@taishi8117 - if you could take a look at this, it will be awesome. |
it looks fine to me 👍 |
let us wait until @taishi8117 gives feedback. |
builder = TopologyBuilder(name=sys.argv[1]) | ||
|
||
word_spout = builder.add_spout("word_spout", WordSpout, par=2) | ||
count_bolt = builder.add_bolt("half_ack_bolt", HalfAckBolt, par=2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change the variable name to half_ack_bolt
?
@kramasamy @objmagic I made some comments, but other than that, this PR looks fine to me. |
@taishi8117 I have addressed your comments in the latest commit. |
seems integration test is very unstable. restarted CI... |
Can you identify which integration test is unstable?
|
seems to me each one of them failed before (retried > 25 times) |
restarted CI and now it's fine. |
This patch adds more default metrics for Python topology, namely:
This PR also adds a half-acking topology example.
related to #1264