Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

fix get_heron_dir #3731

Merged
merged 5 commits into from
Nov 12, 2021
Merged

Conversation

thinker0
Copy link
Member

Fix #3730

@joshfischer1108
Copy link
Member

Let's wait until CI passes before merging

@nicknezis
Copy link
Contributor

My testing on another branch is currently failing and I think it might be related to this issue.

@nicknezis nicknezis self-requested a review November 12, 2021 19:37
@nicknezis nicknezis self-assigned this Nov 12, 2021
@nicknezis nicknezis merged commit c32c09a into apache:master Nov 12, 2021
@nicknezis
Copy link
Contributor

@thinker0 I'm still having issues with the build. I originally got this issue (python-zk/kazoo#609) in the heron-tracker, but I bumped the version of Kazoo dependency to 2.8.0. That fixed that issue, but I now get the following:

kubectl -n pir logs heronkube-tools-bf7cf598-w46bs -c heron-tracker
[2021-11-12 21:28:15 +0000] [ERROR]: Exception while getting state_managers.
Traceback (most recent call last):
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/.bootstrap/pex/pex.py", line 476, in execute
    exit_value = self._wrap_coverage(self._wrap_profiling, self._execute)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/.bootstrap/pex/pex.py", line 401, in _wrap_coverage
    return runner(*args)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/.bootstrap/pex/pex.py", line 432, in _wrap_profiling
    return runner(*args)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/.bootstrap/pex/pex.py", line 532, in _execute
    return self.execute_entry(self._pex_info.entry_point)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/.bootstrap/pex/pex.py", line 679, in execute_entry
    return self.execute_module(entry_point, alter_sys)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/.bootstrap/pex/pex.py", line 691, in execute_module
    runpy.run_module(module_name, run_name="__main__", alter_sys=alter_sys)
  File "/usr/lib/python3.8/runpy.py", line 207, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.8/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/heron/tools/tracker/src/python/main.py", line 231, in <module>
    cli() # pylint: disable=no-value-for-parameter
  File "/root/.pex/installed_wheels/386b0f74344f046086c84bc4bc5c4f27f2f9a108/click-7.1.2-py2.py3-none-any.whl/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/root/.pex/installed_wheels/386b0f74344f046086c84bc4bc5c4f27f2f9a108/click-7.1.2-py2.py3-none-any.whl/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/root/.pex/installed_wheels/386b0f74344f046086c84bc4bc5c4f27f2f9a108/click-7.1.2-py2.py3-none-any.whl/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/root/.pex/installed_wheels/386b0f74344f046086c84bc4bc5c4f27f2f9a108/click-7.1.2-py2.py3-none-any.whl/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/heron/tools/tracker/src/python/main.py", line 204, in cli
    application = Application(config)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/heron/tools/tracker/src/python/main.py", line 50, in __init__
    self.tracker.synch_topologies()
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/heron/tools/tracker/src/python/tracker.py", line 121, in synch_topologies
    self.state_managers = statemanagerfactory.get_all_state_managers(self.config.statemgr_config)
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/heron/statemgrs/src/python/statemanagerfactory.py", line 48, in get_all_state_managers
    raise ex
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/heron/statemgrs/src/python/statemanagerfactory.py", line 43, in get_all_state_managers
    state_managers.extend(get_all_zk_state_managers(conf))
  File "/root/.pex/unzipped_pexes/3a087e21a1133580c59570c4b7dc76153a7fb1f5/heron/statemgrs/src/python/statemanagerfactory.py", line 72, in get_all_zk_state_managers
    tunnelhost = location['tunnelhost']
KeyError: 'tunnelhost'

@joshfischer1108
Copy link
Member

@nicknezis It looks like the CI build failed on this PR. I have not looked into the details of why it failed yet. Can we revert the merge until proven it will pass?

@nicknezis
Copy link
Contributor

Yes, but we also need to revert this issue: #3727

@thinker0
Copy link
Member Author

it will fix

  pex_file = os.environ.get('PEX', None)
  if pex_file is not None:
    return normalized_class_path(str(Path(pex_file).resolve(strict=True).parent.parent))

@thinker0 thinker0 deleted the feature/fix-get-heron-dir branch November 12, 2021 23:39
@thinker0
Copy link
Member Author

#3734

@nicknezis
Copy link
Contributor

That fixed it. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In PexBuilder, ~/.heron/conf and ~/.heron/release.yaml are located in the wrong package.
3 participants