Fix '"is" with a literal' syntax warnings #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Thank you. Can you please amend your commit and follow the CONTRIBUTING.MD guidelines? |
|
Notes: relates to #607 |
arrdem
force-pushed
the
arrdem/py38-is-with-literal-fix
branch
from
6a586a6
to
94cec07
Compare
As of Python 3.8, "is" with a literal is a syntax warning because of the confusion between equality and instance identity it represents. Issue python-zk#607
arrdem
force-pushed
the
arrdem/py38-is-with-literal-fix
branch
from
94cec07
to
d4e9336
Compare
|
Message amended and updated against master. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Python 3.8, "is" with a literal is a syntax warning and may become an error in the future. Kazoo ran afoul of this in a few places.
Fixes