Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update scripts for validating HugeGraph 1.2.0 release #307
chore: update scripts for validating HugeGraph 1.2.0 release #307
Changes from 7 commits
cf4509d
ae3b377
4fad22a
b5d3678
2e67f02
1ff6407
c974072
02c658c
cf577ed
1450dd2
aff76b9
4048708
65955de
8a82a73
d9938e3
c415545
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuxiaocs7 @aroundabout could we add some basic curl check like
curl localhost:8088/xxxAPI
to ensure the hubble runs well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that
start_hubble.sh
included the check:https://github.com/apache/incubator-hugegraph-toolchain/blob/773469c069bc79e9e8159349a5b086f6da3f97eb/hugegraph-hubble/hubble-dist/assembly/static/bin/start-hubble.sh#L83-L94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it only check server but not hubble itself (it's good to enhance the check in
start-hubble
later), currently we could check it in our scriptThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pengzna here can be improved in next PR~