chore: update scripts for validating HugeGraph 1.2.0 release #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imbajin PTAL~ |
imbajin
reviewed
Dec 17, 2023
imbajin
reviewed
Dec 18, 2023
Comment on lines
+202
to
+203
| bin/start-hubble.sh || exit | ||
| bin/stop-hubble.sh || exit |
There was a problem hiding this comment.
@liuxiaocs7 @aroundabout could we add some basic curl check like curl localhost:8088/xxxAPI to ensure the hubble runs well?
There was a problem hiding this comment.
I remember that start_hubble.sh included the check:
There was a problem hiding this comment.
I remember that
start_hubble.shincluded the check:
seems it only check server but not hubble itself (it's good to enhance the check in start-hubble later), currently we could check it in our script
There was a problem hiding this comment.
@Pengzna here can be improved in next PR~
imbajin
approved these changes
Dec 18, 2023
github-actions bot
pushed a commit
to VGalaxies/incubator-hugegraph-doc
that referenced
this pull request
Dec 18, 2023
|
related #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subtask of hugegraph/actions#5, and it includes the following changes:
validate-release.shandvalidate-release.ymlwith https://github.com/hugegraph/actions/blob/master/.github/workflows/validate-release.yml.Currently, steps 7 (validate the binary packages) and 8 (run the binary packages in the server) in this script have detected some issues that await further resolution.