-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): optimize adjacent-edges query #2408
feat(api): optimize adjacent-edges query #2408
Conversation
…here are no edges of the specified label type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2408 +/- ##
============================================
+ Coverage 66.23% 66.30% +0.07%
- Complexity 827 829 +2
============================================
Files 511 511
Lines 42582 42622 +40
Branches 5935 5947 +12
============================================
+ Hits 28204 28261 +57
+ Misses 11566 11552 -14
+ Partials 2812 2809 -3 ☔ View full report in Codecov by Sentry. |
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/graph/EdgeAPI.java
Outdated
Show resolved
Hide resolved
03f235c
to
8a0e07f
Compare
...ph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
...ph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
...ph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
...ph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/schema/EdgeLabel.java
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/query/Condition.java
Outdated
Show resolved
Hide resolved
...h-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/graph/EdgeAPI.java
Outdated
Show resolved
Hide resolved
...h-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/schema/EdgeLabel.java
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/schema/EdgeLabel.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Relevant issue: #2255 Gremlin Query: For adjacency edge queries, if a vertex does not belong to the adjacent vertices of this edge, filter out that vertex. --------- Co-authored-by: imbajin <jin@apache.org>
Purpose of the PR
Main Changes
Relevant issue:#2255
Gremlin Query: For adjacency edge queries, if a vertex does not belong to the adjacent vertices of this edge, filter out that vertex.
Verifying these changes
edge data
![image](https://private-user-images.githubusercontent.com/55943045/294132276-98f8989a-2042-477f-ab58-2fc8dd2d4b3c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzQ3MTMsIm5iZiI6MTczOTAzNDQxMywicGF0aCI6Ii81NTk0MzA0NS8yOTQxMzIyNzYtOThmODk4OWEtMjA0Mi00NzdmLWFiNTgtMmZjOGRkMmQ0YjNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE3MDY1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM5MGUzODAzOGYwYTdmMTAzNjI1ZGQ3NjMzZjhhN2UyNDUzNzRjMzM5MDg4NDMyYzNkYzkyYmJjYTk1MDU1NGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ZHV7a_52_U4UG2Xmo87zIQVeAzTMnRS3VQP2zr_CK-I)
GET http://127.0.0.1:8080/graphs/hugegraph/graph/edges?label=test
![image](https://private-user-images.githubusercontent.com/55943045/294131666-e188a94c-8009-49d0-a5f8-375b2c4d3a9a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzQ3MTMsIm5iZiI6MTczOTAzNDQxMywicGF0aCI6Ii81NTk0MzA0NS8yOTQxMzE2NjYtZTE4OGE5NGMtODAwOS00OWQwLWE1ZjgtMzc1YjJjNGQzYTlhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE3MDY1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNiYmRmYjc4OGNiNzg5MTVjMGViNTQ3M2ZiZjc5ZDdkNDQ5ZjhhM2ZmMjBlZGI0ZjY3NGQ1NjQ1MjQ4OWFhZGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9wKToELJjxgtDogRWsNDxrIjftqcHAxu7pot4Kc1pjw)
Does this PR potentially affect the following parts?
org.apache.hugegraph.api.graph.EdgeAPI#list
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need