fix(server): reinitialize the progress to set up graph auth friendly #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2411 +/- ##
============================================
- Coverage 66.23% 66.22% -0.01%
+ Complexity 830 828 -2
============================================
Files 511 511
Lines 42595 42596 +1
Branches 5942 5942
============================================
- Hits 28211 28210 -1
- Misses 11568 11572 +4
+ Partials 2816 2814 -2 ☔ View full report in Codecov by Sentry. |
imbajin
changed the title
imbajin
reviewed
Jan 9, 2024
hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugegraph/cmd/InitStore.java
Outdated
Show resolved
Hide resolved
…raph/cmd/InitStore.java Co-authored-by: imbajin <jin@apache.org>
javeme
previously approved these changes
Jan 13, 2024
| @@ -101,6 +101,8 @@ private static HugeGraph initGraph(String configPath) throws Exception { | |||
| LOG.info("Skip init-store due to the backend store of '{}' " + | |||
| "had been initialized", graph.name()); | |||
| backendStoreInfo.checkVersion(); | |||
| // Init the required information for creating the admin account (when switch from non-auth mode to auth mode) | |||
There was a problem hiding this comment.
please wrap line if exceed 80~100 chars
imbajin
approved these changes
Jan 15, 2024
javeme
approved these changes
Jan 17, 2024
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Jan 17, 2024
imbajin
reviewed
Jan 18, 2024
Comment on lines
101
to
102
| LOG.info("Skip init-store due to the backend store of '{}' " + | ||
| "had been initialized", graph.name()); |
Z-HUANT
added a commit
to Z-HUANT/incubator-hugegraph
that referenced
this pull request
Jan 23, 2024
Z-HUANT
added a commit
to Z-HUANT/incubator-hugegraph
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
修复需要重新初始化数据库才能设置 auth 的问题
fixed #125 (comment)
Main Changes
Switch to auth-mode without removing graph data (不需要重新初始化数据库就可以设置 auth)
Verifying these changes
自己测试流程如下
Does this PR potentially affect the following parts?
影响 init-store
Documentation Status
Doc - TODODoc - DoneDoc - No NeedDoc：apache/incubator-hugegraph-doc#320