Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): reinitialize the progress to set up graph auth friendly #2411

Merged
merged 3 commits into from
Jan 17, 2024
Merged

fix(server): reinitialize the progress to set up graph auth friendly #2411

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4d0f05
fix：Reinitializing the database is required to set up authentication.
Z-HUANT Jan 9, 2024
46e0077
Update hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugeg…
Z-HUANT Jan 11, 2024
4c00dea
fix: modify the comments
Z-HUANT Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugegraph/cmd/InitStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@
LOG.info("Skip init-store due to the backend store of '{}' " +
"had been initialized", graph.name());
Comment on lines 101 to 102
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Z-HUANT seems we could move this log after L108? (due to the code logic)

could enhance it in another reviewed PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put it in this PR later: #2408.

backendStoreInfo.checkVersion();
// Init the required information for creating the admin account (when switch from non-auth mode to auth mode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wrap line if exceed 80~100 chars

graph.initSystemInfo();

Check warning on line 105 in hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugegraph/cmd/InitStore.java

View check run for this annotation

Codecov / codecov/patch

hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugegraph/cmd/InitStore.java#L105 

Added line #L105 was not covered by tests
} else {
initBackend(graph);
}
Expand Down
Loading