Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make IDEA support IssueNavigationLink and add icon #2521

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Apr 14, 2024

Purpose of the PR

as title, similar: apache/incubator-hugegraph-toolchain#600

before:
Snipaste_2024-04-15_01-11-17
after:
image

image

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feature New feature labels Apr 14, 2024
VGalaxies
VGalaxies previously approved these changes Apr 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 15, 2024
@VGalaxies
Copy link
Contributor

VGalaxies commented Apr 15, 2024

@liuxiaocs7 Perhaps the license header comment in XML files should not include ~ (to maintain consistency with other XML files), does apache/incubator-hugegraph-toolchain#600 also need to be modified for that?

image

@liuxiaocs7
Copy link
Member Author

@liuxiaocs7 Perhaps the license header comment in XML files should not include ~ (to maintain consistency with other XML files), does apache/incubator-hugegraph-toolchain#600 also need to be modified for that?

image

Thanks, Done. yes, i'll change it later.

@VGalaxies VGalaxies requested a review from imbajin April 15, 2024 06:43
@imbajin imbajin merged commit 906112c into apache:master Apr 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants