Skip to content

Commit

Permalink
[MINOR] Fix Travis CI + Bring back support for Java 8 (#296)
Browse files Browse the repository at this point in the history
**Major changes:**
- Fixes Travis CI script that have been failing due to gpg error
- Bring back support for Java 8, as Hadoop and REEF still needs support for Java 8 (reverts #291)

**Minor changes to note:**
- None

**Tests for the changes:**
- N/A

**Other comments:**
- None

Closes #296
  • Loading branch information
wonook authored Jun 26, 2020
1 parent 4590ab6 commit 24b246d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ dist: trusty
# For maven builds
language: java
jdk:
- oraclejdk8
- oraclejdk11
- openjdk11
env:
Expand All @@ -30,7 +31,6 @@ env:
jobs:
- GOAL="verify -B -q -ff -Dsurefire.useFile=false -Dorg.slf4j.simpleLogger.defaultLogLevel=info"
before_install:
- sudo apt update && sudo apt install -y libgif-dev
- nvm install node # for Web UI build
install: true
script:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Please refer to the [Contribution guideline](.github/CONTRIBUTING.md) to contrib
## Nemo prerequisites and setup

### Prerequisites
* Java 11
* Java 8 or later (tested on Java 8 and Java 11)
* Maven
* YARN settings
* Download Hadoop 2.7.2 at https://archive.apache.org/dist/hadoop/common/hadoop-2.7.2/
Expand Down
9 changes: 5 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ under the License.
</scm>

<properties>
<java.version>11</java.version>
<java.version>1.8</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<maven.compiler.version>3.8.1</maven.compiler.version>
Expand Down Expand Up @@ -176,9 +176,10 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven.compiler.version}</version>
<configuration>
<release>${java.version}</release>
</configuration>
<!-- Uncomment when dropping support for Java 8 -->
<!--<configuration>-->
<!-- <release>${java.version}</release>-->
<!--</configuration>-->
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
Expand Down

0 comments on commit 24b246d

Please sign in to comment.