[NEMO-440] Migrate to Java11 and use Java 11 Features #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnyangk Could you take a look at the PR? It's super simple 😄 |
|
I guess Java 10 and below (including Java 8) are no longer supported by Nemo? I am neutral on this, but it might be helpful to send an email to the Nemo mailing list about dropping Java 8 support to give a heads up before proceeding? (since perhaps not all of the folks in the community are following each github issue) |
|
Sure, that would be a good idea. I'll seek for opinions. |
|
@johnyangk Here are a few replies on the email thread. I also think that it would be nice to move forward. 😄
|
johnyangk
approved these changes
Mar 23, 2020
jeongyooneo
pushed a commit
that referenced
this pull request
Apr 19, 2020
JIRA: [NEMO-440: Migrate to Java11 and use Java 11 Features](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-440) **Major changes:** - Update readme **Minor changes to note:** - None **Tests for the changes:** - None **Other comments:** - Java 11 support has been done in PR #291 - Nemo build fails with Java 8 due to the pom configuration that does not work with Java 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-440: Migrate to Java11 and use Java 11 Features
Major changes:
Minor changes to note:
Tests for the changes:
Other comments:
Closes #291