MINOR: Remove redudant LocalLogManager#10325
Merged
cmccabe merged 1 commit intoapache:trunkfrom Apr 2, 2021
Merged
Conversation
Member
Author
dengziming
changed the title
dengziming
force-pushed
the
minor-remove-redudant-LocalLogManager
branch
from
a57fb25 to
4da87ea
Compare
Contributor
|
Thanks for spotting this, @dengziming . I thought we fixed this already, but I guess not. The correct fix is to delete this code completely from the main directory, since it is used only for testing. This PR seems to do the reverse. Can you please change it around so the code under Also, we want to keep the comments (or to put another way, we don't need to change the version in |
dengziming
force-pushed
the
minor-remove-redudant-LocalLogManager
branch
from
4da87ea to
e564a3a
Compare
Member
Author
|
@cmccabe done! Thank you for your reply, PTAL again. |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Apr 4, 2021
…e-allocations-lz4 * apache-github/trunk: (243 commits) KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes in 3.0 (apache#10450) KAFKA-3968: fsync the parent directory of a segment file when the file is created (apache#10405) KAFKA-12283: disable flaky testMultipleWorkersRejoining to stabilize build (apache#10408) MINOR: remove KTable.to from the docs (apache#10464) MONOR: Remove redudant LocalLogManager (apache#10325) MINOR: support ImplicitLinkedHashCollection#sort (apache#10456) KAFKA-12587 Remove KafkaPrincipal#fromString for 3.0 (apache#10447) KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager (apache#10282) MINOR: Improve reproducability of raft simulation tests (apache#10422) KAFKA-12474: Handle failure to write new session keys gracefully (apache#10396) KAFKA-12593: Fix Apache License headers (apache#10452) MINOR: Fix typo in MirrorMaker v2 documentation (apache#10433) KAFKA-12600: Remove deprecated config value `default` for client config `client.dns.lookup` (apache#10458) KAFKA-12952: Remove deprecated LogConfig.Compact (apache#10451) Initial commit (apache#10454) KAFKA-12575: Eliminate Log.isLogDirOffline boolean attribute (apache#10430) KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command (apache#10443) MINOR: Fix docs for end-to-end record latency metrics (apache#10449) MINOR Replaced File with Path in LogSegmentData. (apache#10424) KAFKA-12583: Upgrade netty to 4.1.62.Final ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
We have 2 identical LocalLogManager in
src/main/org.apache.kafka.metalogandsrc/test/org.apache.kafka.metalog, the only difference is that the test class have more docs, I just move the docs from test to src and remove test class.Summary of testing strategy (including rationale)
QA
Committer Checklist (excluded from commit message)