Skip to content

MINOR Replaced File with Path in LogSegmentData.#10424

Merged
junrao merged 3 commits intoapache:trunkfrom
satishd:tier-spi-minor
Mar 31, 2021
Merged

MINOR Replaced File with Path in LogSegmentData.#10424
junrao merged 3 commits intoapache:trunkfrom
satishd:tier-spi-minor

Conversation

@satishd
Copy link
Member

@satishd satishd commented Mar 29, 2021

  • Replaced File with Path in LogSegment Data.
  • Addressed a few minor renames and comments.

This is a followup of #10173

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@satishd satishd changed the title MINOR Replaced File with Path in LogSegment Data. MINOR Replaced File with Path in LogSegmentData. Mar 29, 2021
Addressed few minor renames and comments.
Copy link
Contributor

@kowshik kowshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satishd Thanks for the PR! LGTM. Just small comment below.

@kowshik
Copy link
Contributor

kowshik commented Mar 29, 2021

cc @junrao @ijuma for review

@satishd
Copy link
Member Author

satishd commented Mar 30, 2021

@kowshik Addressed the comment.

Copy link
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satishd : Thanks for the PR. Just a few minor comments below.

 Aligned text in javadoc and corrected field names in toString representation.
@satishd
Copy link
Member Author

satishd commented Mar 31, 2021

Thanks @junrao for the review. Addressed the comments in 3c4d6e5 commit.

Copy link
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satishd : Thanks for the PR. LGTM

@junrao junrao merged commit 3829df1 into apache:trunk Mar 31, 2021
Terrdi pushed a commit to Terrdi/kafka that referenced this pull request Apr 1, 2021
Replaced File with Path in LogSegment Data.

This is a followup of apache#10173

Reviewers: Kowshik Prakasam <kprakasam@confluent.io>, Jun Rao <junrao@gmail.com>
ijuma added a commit to ijuma/kafka that referenced this pull request Apr 4, 2021
…e-allocations-lz4

* apache-github/trunk: (243 commits)
  KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes in 3.0 (apache#10450)
  KAFKA-3968: fsync the parent directory of a segment file when the file is created (apache#10405)
  KAFKA-12283: disable flaky testMultipleWorkersRejoining to stabilize build (apache#10408)
  MINOR: remove KTable.to from the docs (apache#10464)
  MONOR: Remove redudant LocalLogManager (apache#10325)
  MINOR: support ImplicitLinkedHashCollection#sort (apache#10456)
  KAFKA-12587 Remove KafkaPrincipal#fromString for 3.0 (apache#10447)
  KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager (apache#10282)
  MINOR: Improve reproducability of raft simulation tests (apache#10422)
  KAFKA-12474: Handle failure to write new session keys gracefully (apache#10396)
  KAFKA-12593: Fix Apache License headers (apache#10452)
  MINOR: Fix typo in MirrorMaker v2 documentation (apache#10433)
  KAFKA-12600: Remove deprecated config value `default` for client config `client.dns.lookup` (apache#10458)
  KAFKA-12952: Remove deprecated LogConfig.Compact (apache#10451)
  Initial commit (apache#10454)
  KAFKA-12575: Eliminate Log.isLogDirOffline boolean attribute (apache#10430)
  KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command (apache#10443)
  MINOR: Fix docs for end-to-end record latency metrics (apache#10449)
  MINOR Replaced File with Path in LogSegmentData. (apache#10424)
  KAFKA-12583: Upgrade netty to 4.1.62.Final
  ...
satishd added a commit to satishd/kafka that referenced this pull request May 31, 2021
Replaced File with Path in LogSegment Data.

This is a followup of apache#10173

Reviewers: Kowshik Prakasam <kprakasam@confluent.io>, Jun Rao <junrao@gmail.com>
kamalcph pushed a commit to satishd/kafka that referenced this pull request Jun 21, 2021
Replaced File with Path in LogSegment Data.

This is a followup of apache#10173

Reviewers: Kowshik Prakasam <kprakasam@confluent.io>, Jun Rao <junrao@gmail.com>
satishd added a commit to satishd/kafka that referenced this pull request Aug 12, 2021
Summary:
Replaced File with Path in LogSegment Data.

This is a followup of apache#10173

apache-reviewers: Kowshik Prakasam <kprakasam@confluent.io>, Jun Rao <junrao@gmail.com>
(cherry picked from commit 3829df1)

Reviewers: #ldap_kafka_admins, kchandraprakash

Reviewed By: #ldap_kafka_admins, kchandraprakash

JIRA Issues: DKAFC-868

Differential Revision: https://code.uberinternal.com/D6303171
divijvaidya pushed a commit to Hangleton/kafka that referenced this pull request Apr 28, 2022
Summary:
Replaced File with Path in LogSegment Data.

This is a followup of apache#10173

apache-reviewers: Kowshik Prakasam <kprakasam@confluent.io>, Jun Rao <junrao@gmail.com>
(cherry picked from commit 3829df1)

Reviewers: #ldap_kafka_admins, kchandraprakash

Reviewed By: #ldap_kafka_admins, kchandraprakash

JIRA Issues: DKAFC-868

Differential Revision: https://code.uberinternal.com/D6303171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants