KAFKA-12782: Javadocs search sends you to a non-existent URL#10758
KAFKA-12782: Javadocs search sends you to a non-existent URL#10758jlprat wants to merge 1 commit intoapache:trunkfrom
Conversation
This is just a workaround to solve this problem while we are still using JDK11. Once moving to, presumably, JDK17 this change won't be needed anymore and could be deleted safely. See https://bugs.openjdk.java.net/browse/JDK-8215291 This change includes a snippet of code copied from JDK 12+
|
cc @ableegoldman as you opened the Jira ticket, maybe you'd like to review this one? |
|
Test failures were known flaky tests. Added a comment on the corresponding Jira's |
|
To be honest I don't have much context on the javadocs but I will take a look. Maybe @ijuma can help review |
|
Sure @ableegoldman , no worries. I just mentioned you as you were the one who created the ticket. |
|
Thanks for looking into this. Can we switch the release requirement to be Java 15 instead of Java 11 then? We can then switch to Java 17 once that's out and stick to that for a while. |
|
Hi @ijuma, yes, if you would generate the Javadocs with JDK 15 (or 16) instead of 11, it would work (I tried it myself locally). Then one only needs to modify the |
|
Yes, let's go with 15 since Kafka doesn't work with 16 yet. |
|
Shall, I close this PR and open a new one with the modified |
|
Or just replace the code in this branch. Whatever you prefer. |
|
Closed in favor of #10780 |
This is just a workaround to solve this problem while we are still using
JDK11.
Once moving to, presumably, JDK17 this change won't be needed
anymore and could be deleted safely. See https://bugs.openjdk.java.net/browse/JDK-8215291
This change includes a snippet of code copied from JDK 12+
I'm not sure if an extra header needs to be added for the piece of code I copied over, or if I would need to implement it from scratch.
Committer Checklist (excluded from commit message)