Skip to content

KAFKA-12782: Javadocs search sends you to a non-existent URL#10758

Closed
jlprat wants to merge 1 commit intoapache:trunkfrom
jlprat:KAFKA-12782-Javadocs-search-sends-you-to-a-non-existent-URL
Closed

KAFKA-12782: Javadocs search sends you to a non-existent URL#10758
jlprat wants to merge 1 commit intoapache:trunkfrom
jlprat:KAFKA-12782-Javadocs-search-sends-you-to-a-non-existent-URL

Conversation

@jlprat
Copy link
Contributor

@jlprat jlprat commented May 25, 2021

This is just a workaround to solve this problem while we are still using
JDK11.
Once moving to, presumably, JDK17 this change won't be needed
anymore and could be deleted safely. See https://bugs.openjdk.java.net/browse/JDK-8215291

This change includes a snippet of code copied from JDK 12+

I'm not sure if an extra header needs to be added for the piece of code I copied over, or if I would need to implement it from scratch.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

This is just a workaround to solve this problem while we are still using
JDK11.
Once moving to, presumably, JDK17 this change won't be needed
anymore and could be deleted safely. See https://bugs.openjdk.java.net/browse/JDK-8215291

This change includes a snippet of code copied from JDK 12+
@jlprat
Copy link
Contributor Author

jlprat commented May 25, 2021

cc @ableegoldman as you opened the Jira ticket, maybe you'd like to review this one?

@jlprat
Copy link
Contributor Author

jlprat commented May 25, 2021

Test failures were known flaky tests. Added a comment on the corresponding Jira's

@ableegoldman
Copy link
Member

To be honest I don't have much context on the javadocs but I will take a look. Maybe @ijuma can help review

@jlprat
Copy link
Contributor Author

jlprat commented May 25, 2021

Sure @ableegoldman , no worries. I just mentioned you as you were the one who created the ticket.

@ijuma
Copy link
Member

ijuma commented May 27, 2021

Thanks for looking into this. Can we switch the release requirement to be Java 15 instead of Java 11 then? We can then switch to Java 17 once that's out and stick to that for a while.

@jlprat
Copy link
Contributor Author

jlprat commented May 27, 2021

Hi @ijuma, yes, if you would generate the Javadocs with JDK 15 (or 16) instead of 11, it would work (I tried it myself locally). Then one only needs to modify the release.py file to accomplish this.
I could create a PR with those changes if you like.

@ijuma
Copy link
Member

ijuma commented May 27, 2021

Yes, let's go with 15 since Kafka doesn't work with 16 yet.

@jlprat
Copy link
Contributor Author

jlprat commented May 27, 2021

Shall, I close this PR and open a new one with the modified release.py?

@ijuma
Copy link
Member

ijuma commented May 27, 2021

Or just replace the code in this branch. Whatever you prefer.

@jlprat
Copy link
Contributor Author

jlprat commented May 27, 2021

Closed in favor of #10780

@jlprat jlprat closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments