KAFKA-12782: Fix Javadocs generation by upgrading JDK#10780
KAFKA-12782: Fix Javadocs generation by upgrading JDK#10780ijuma merged 2 commits intoapache:trunkfrom
Conversation
This, upgrades JDK to version 15 for the docs generation, this way we can circumvent bug https://bugs.openjdk.java.net/browse/JDK-8215291 present in JDK11
| cmd("Building artifacts", "./gradlew clean && ./gradlewAll releaseTarGz", cwd=kafka_dir, env=jdk8_env, shell=True) | ||
| cmd("Copying artifacts", "cp %s/core/build/distributions/* %s" % (kafka_dir, artifacts_dir), shell=True) | ||
| cmd("Building docs", "./gradlew clean aggregatedJavadoc", cwd=kafka_dir, env=jdk11_env) | ||
| cmd("Building docs", "./gradlew clean aggregatedJavadoc", cwd=kafka_dir, env=jdk15_env) |
There was a problem hiding this comment.
This one I'm not sure it's really needed as I never executed that part of the script.
| gradle_version_override = docs_release_version(version) | ||
|
|
||
| cmd("Building docs", "./gradlew -Pversion=%s clean siteDocsTar aggregatedJavadoc" % gradle_version_override, cwd=REPO_HOME, env=jdk11_env) | ||
| cmd("Building docs", "./gradlew -Pversion=%s clean siteDocsTar aggregatedJavadoc" % gradle_version_override, cwd=REPO_HOME, env=jdk15_env) |
There was a problem hiding this comment.
This, together with change in line 259, are the changes needed
|
Hi, @ijuma ready for you to review |
release.py
Outdated
| @@ -512,6 +512,7 @@ def command_release_announcement_email(): | |||
|
|
|||
| jdk8_env = get_jdk(prefs, 8) | |||
| jdk11_env = get_jdk(prefs, 11) | |||
There was a problem hiding this comment.
Most probably, but I never executed that part of the script.
There was a problem hiding this comment.
I will push a commit without this line
There was a problem hiding this comment.
Can you search the file for references to this? If there are none, please remove it.
There was a problem hiding this comment.
The only reference was at line 604, which I replaced for JDK15
|
An easy way to test this locally, is to search a Kafka class that contains a Javadoc link to a Standard Java Class. |
|
We'll hopefully switch to JDK 16 before the 3.0 release. |
|
@jlprat See #10702 (comment) for additional things that need to be fixed. |
2 participants
This, upgrades JDK to version 15 for the docs generation, this way we
can circumvent bug https://bugs.openjdk.java.net/browse/JDK-8215291
present in JDK11
Committer Checklist (excluded from commit message)