Skip to content

KAFKA-12892: disable testChrootExistsAndRootIsLocked#10820

Merged
omkreddy merged 1 commit intoapache:trunkfrom
showuon:KAFKA-12892
Jun 11, 2021
Merged

KAFKA-12892: disable testChrootExistsAndRootIsLocked#10820
omkreddy merged 1 commit intoapache:trunkfrom
showuon:KAFKA-12892

Conversation

@showuon
Copy link
Member

@showuon showuon commented Jun 4, 2021

Detail is described in https://issues.apache.org/jira/browse/KAFKA-12892.
Thanks.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon
Copy link
Member Author

showuon commented Jun 4, 2021

@ijuma @omkreddy , could you take a look? This test keeps failing the jenkins build, I think we should disable it before we know how to avoid breaking jenkins build. Thanks.

@ijuma
Copy link
Member

ijuma commented Jun 4, 2021

@omkreddy I will leave it to you to review this since you reviewed the original PR. If this is failing often, it makes sense to disable temporarily, but we need a JIRA to fix the test.

@showuon
Copy link
Member Author

showuon commented Jun 4, 2021

@ijuma , KAFKA-12892 is the JIRA ticket. Thanks.

Copy link
Member

@soarez soarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I broke this. The teardown for ZooKeeperTestHarness doesn't quite work as I expected. I'll have a look at making this test work properly.

@showuon
Copy link
Member Author

showuon commented Jun 5, 2021

Triggering another test to make sure disabling the test won't break the build.

@showuon
Copy link
Member Author

showuon commented Jun 5, 2021

2 PR builds have no build failure. This PR can fix the trunk build failure issue. Thanks.

@omkreddy
Copy link
Contributor

omkreddy commented Jun 5, 2021

@showuon I have merged the PR #10821. Let us monitor any build failures.

@showuon
Copy link
Member Author

showuon commented Jun 5, 2021

@omkreddy , sure. Hope it fixes the build. Thank you.

@showuon
Copy link
Member Author

showuon commented Jun 7, 2021

@omkreddy , unfortunately, the trunk build is still failing with InvalidAclException after #10821 merged. I think we should disable this test first (This PR triggered PR build 3 times and never failed the jenkins build), and maybe we should think another way to do the test (and should have multiple runs to verify it won't break the tests). Thank you.

@showuon
Copy link
Member Author

showuon commented Jun 10, 2021

@omkreddy @ijuma , the trunk build keeps failing with InvalidAclException at least 1 build group (sometimes 2 or 3 failed) after the fix merged (in build # 199). I think this is worse than flaky tests since the build terminated suddenly without build report output. I still think we need to disable the failing test soon, and have further investigation. What do you think?
image

Copy link
Contributor

@omkreddy omkreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@showuon Thanks for the PR. lets merge this and analyze the acl errors separately.

@omkreddy omkreddy merged commit 6de37e5 into apache:trunk Jun 11, 2021
@ijuma
Copy link
Member

ijuma commented Jun 11, 2021

Can we file a JIRA to re-enable this test?

@soarez
Copy link
Member

soarez commented Jun 11, 2021

@showuon
Copy link
Member Author

showuon commented Jun 12, 2021

Thanks @omkreddy @ijuma @soarez , finally see the trunk build back to yellow light!
image

@showuon showuon deleted the KAFKA-12892 branch June 12, 2021 01:46
sakibguy added a commit to sakibguy/kafka that referenced this pull request Jun 12, 2021
KAFKA-12892: Disable testChrootExistsAndRootIsLocked (apache#10820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments