KAFKA-12892: Use dedicated root in ZK ACL test#10821
Merged
omkreddy merged 1 commit intoapache:trunkfrom Jun 5, 2021
Merged
Conversation
Changes: - Use a dedicated znode for the test - Move the test to `KafkaZkClientTest` - there is no longer a need to keep it in a separate `ZooKeeperTestHarness`
Member
|
@soarez , thanks for the quick fix. But unfortunately, the PR build still failed for "JDK 15 and Scala 2.13" build. I don't see the AclException in the log, but still failed the build. FYI. |
Contributor
|
Changes LGTM. let us re-run the tests. |
3 tasks
sakibguy
added a commit
to sakibguy/kafka
that referenced
this pull request
Jun 6, 2021
KAFKA-12892: Use dedicated root in ZK ACL test (apache#10821)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the
testChrootExistsAndRootIsLockedtest in a separateZookeeperTestHarnessisn't enough to prevent the ACL changes to the ZK root from affecting other integration tests. So instead, let's use a dedicated znode for this test. It still works becausemakeSurePersistentPathExistsusescreateRecursive, which will recurse and act the same for the root or a given znode.Changes:
KafkaZkClientTest- there is no longer a need tokeep it in a separate
ZooKeeperTestHarnessRelated: #10820
Committer Checklist (excluded from commit message)