MINOR: Use right enum value for broker registration change#12236
Merged
jsancio merged 1 commit intoapache:trunkfrom Aug 2, 2022
Merged
MINOR: Use right enum value for broker registration change#12236jsancio merged 1 commit intoapache:trunkfrom
jsancio merged 1 commit intoapache:trunkfrom
Conversation
Member
Author
dengziming
force-pushed
the
minor-BrokerRegistrationChangeRecord
branch
from
06bff4e to
c4f7665
Compare
Member
|
@dengziming Thanks for improving this! There are a lot of test failures. Can you take a look at those? |
Member
|
@dengziming I merge |
Member
Author
Thank you. |
Member
|
We need to make sure that we handle these changes depending on which commit gets merged first: db82247#diff-7e2c147bf9c397298568e943069881bd7f01dd9c391f2a8ead700e232987e0aaL96-R107 |
Member
|
@dengziming I merged KAFKA-13916. When you have sometime can you take a look at this change again? |
dengziming
force-pushed
the
minor-BrokerRegistrationChangeRecord
branch
from
0a6669e to
c0690fc
Compare
Member
Author
|
ping @jsancio |
dengziming
force-pushed
the
minor-BrokerRegistrationChangeRecord
branch
from
c0690fc to
76ff069
Compare
Member
Author
|
cc @jsancio. |
Member
Author
|
cc @jsancio |
jsancio
approved these changes
Aug 2, 2022
Member
jsancio
left a comment
jsancio
left a comment
There was a problem hiding this comment.
LGTM. After searching the code, it looks like this PR updated all of the call sites. Thanks for the improvements and tests.
cmccabe
pushed a commit
that referenced
this pull request
Aug 3, 2022
The code used BrokerRegistrationFencingChange.FENCE when unfencing a broker and used BrokerRegistrationFencingChange.UNFENCE when fencing a broker, this is confusing. This commit flips the values of the two enums and changes their usage at all of the call sites. Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com>
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Aug 5, 2022
…(5 August 2022) Version related conflicts: * Jenkinsfile * gradle.properties * streams/quickstart/java/pom.xml * streams/quickstart/java/src/main/resources/archetype-resources/pom.xml * streams/quickstart/pom.xml * tests/kafkatest/__init__.py * tests/kafkatest/version.py * commit 'add7cd85baa61cd0e1430': (66 commits) KAFKA-14136 Generate ConfigRecord for brokers even if the value is unchanged (apache#12483) HOTFIX / KAFKA-14130: Reduce RackAwarenesssTest to unit Test (apache#12476) MINOR: Remove ARM/PowerPC builds from Jenkinsfile (apache#12380) KAFKA-14111 Fix sensitive dynamic broker configs in KRaft (apache#12455) KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest (apache#12468) KAFKA-14129: KRaft must check manual assignments for createTopics are contiguous (apache#12467) KAFKA-13546: Do not fail connector validation if default topic creation group is explicitly specified (apache#11615) KAFKA-14122: Fix flaky test DynamicBrokerReconfigurationTest#testKeyStoreAlter (apache#12452) MINOR; Use right enum value for broker registration change (apache#12236) MINOR; Synchronize access to snapshots' TreeMap (apache#12464) MINOR; Bump trunk to 3.4.0-SNAPSHOT (apache#12463) MINOR: Stop logging 404s at ERROR level in Connect KAFKA-14095: Improve handling of sync offset failures in MirrorMaker (apache#12432) Minor: enable index for emit final sliding window (apache#12461) MINOR: convert some more junit tests to support KRaft (apache#12456) KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run (apache#12441) MINOR: Remove code of removed metric (apache#12453) MINOR: Update comment on verifyTaskGenerationAndOwnership method in DistributedHerder KAFKA-14012: Add warning to closeQuietly documentation about method references of null objects (apache#12321) MINOR: Fix static mock usage in ThreadMetricsTest (apache#12454) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
In
ClusterControlManager.replayandReplicationControlManager, we useBrokerRegistrationFencingChange.FENCEwhen unfencing a broker and useBrokerRegistrationFencingChange.UNFENCEwhen fencing a broker, this is confusing.Summary of testing strategy (including rationale)
Didn't change any logic.
Committer Checklist (excluded from commit message)