Closed
Conversation
Member
Author
|
@cmccabe @hachikuji @dengziming , call for review. Thanks. |
dengziming
reviewed
Jun 23, 2022
Member
There was a problem hiding this comment.
We can use BrokerRegistrationFencingChange.fromValue
Member
Author
There was a problem hiding this comment.
Nice suggestion. Thanks.
Member
Author
|
Thanks @dengziming for the comments. Sorry that I didn't know you already have another PR addressing this issue. Let's waiting for the PR #12236 merged. Thanks. |
showuon
force-pushed
the
KAFKA-13981
branch
from
03ddb18 to
536cdf6
Compare
showuon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New records handled in this PR:
FEATURE_LEVEL_RECORD: featureLevels/FEATURE_NAME -> levelBROKER_REGISTRATION_CHANGE_RECORD:-> brokers/BROKER_ID/isFenced -> true/false
-> brokers/BROKER_ID/registration -> json content
ACCESS_CONTROL_ENTRY_RECORD: acls/ACL_UUID/data -> json contentREMOVE_ACCESS_CONTROL_ENTRY_RECORD: remove acls/ACL_UUIDNO_OP_RECORD: no opTests added.
Committer Checklist (excluded from commit message)