[BUG] Remove duplicate common.message.* from clients:test jar file #12407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When consuming both `kafka-client:3.0.1` and `kafka-client:3.0.1:test` through maven a hygene tool was detecting multiple instances of the same class loaded into the classpath.
CI failures look like they are related to some infrastructure being offline |
|
@tombentley Can you help me get this PR reviewed? |
ijuma
added a commit
to franz1981/kafka
that referenced
this pull request
Aug 12, 2022
* apache-github/trunk: (447 commits) KAFKA-13959: Controller should unfence Broker with busy metadata log (apache#12274) KAFKA-10199: Expose read only task from state updater (apache#12497) KAFKA-14154; Return NOT_CONTROLLER from AlterPartition if leader is ahead of controller (apache#12506) KAFKA-13986; Brokers should include node.id in fetches to metadata quorum (apache#12498) KAFKA-14163; Retry compilation after zinc compile cache error (apache#12507) Remove duplicate common.message.* from clients:test jar file (apache#12407) KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest.java (apache#12484) Fix the rate window size calculation for edge cases (apache#12184) MINOR: Upgrade gradle to 7.5.1 and bump other build/test dependencies (apache#12495) KAFKA-14140: Ensure an offline or in-controlled-shutdown replica is not eligible to join ISR in ZK mode (apache#12487) KAFKA-14114: Add Metadata Error Related Metrics MINOR: BrokerMetadataSnapshotter must avoid exceeding batch size (apache#12486) MINOR: Upgrade mockito test dependencies (apache#12460) KAFKA-14144:; Compare AlterPartition LeaderAndIsr before fencing partition epoch (apache#12489) KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest (apache#12472) MINOR: Update scala version in bin scripts to 2.13.8 (apache#12477) KAFKA-14104; Add CRC validation when iterating over Metadata Log Records (apache#12457) MINOR: add :server-common test dependency to :storage (apache#12488) KAFKA-14107: Upgrade Jetty version for CVE fixes (apache#12440) KAFKA-14124: improve quorum controller fault handling (apache#12447) ...
3 tasks
|
@ijuma Hi - I was checking the latest versions 3.3.1 and I still see the issue that I tried to fix. Does this change need to be picked into one of the release branches, is there a way I can help to get this done? |
|
This will be part of 3.4.0. Is there a strong reason to backport it to older releases? |
|
Thanks for the reply, I would like this fix available sooner since we have to disable jar hell checks in our project to work around this issue for nearly 6 months. Do you have an approximant date for 3.4.0 release? |
|
Likely this month and it would happen before other releases (3.3.2 is imminent so too late for that). |
|
That sounds good, thanks for letting me know. |
peternied
added a commit
to peternied/security
that referenced
this pull request
Aug 21, 2023
JarHell was disabled due to an issue with Kafka where there were multiple copies of the same class packaged inside of a release and test distribution jar. This was resolved with apache/kafka#12407 The Kafka change has been merged, released, and pulled into this repository so we are removing the workaround to supress jar hell issue detection. - Resolves opensearch-project#1938 Signed-off-by: Peter Nied <petern@amazon.com>
3 tasks
peternied
added a commit
to opensearch-project/security
that referenced
this pull request
Aug 22, 2023
JarHell was disabled due to an issue with Kafka where there were multiple copies of the same class packaged inside of a release and test distribution jar. This was resolved with apache/kafka#12407 The Kafka change has been merged, released, and pulled into this repository so we are removing the workaround to supress jar hell issue detection. Signed-off-by: Peter Nied <petern@amazon.com>
opensearch-trigger-bot bot
pushed a commit
to opensearch-project/security
that referenced
this pull request
Aug 22, 2023
JarHell was disabled due to an issue with Kafka where there were multiple copies of the same class packaged inside of a release and test distribution jar. This was resolved with apache/kafka#12407 The Kafka change has been merged, released, and pulled into this repository so we are removing the workaround to supress jar hell issue detection. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 75f529a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consuming both
kafka-client:3.0.1andkafka-client:3.0.1:testthrough maven a hygene tool was detecting multiple instances of the same
class loaded into the classpath.
Verified this change by building locally with a before and after build with
./gradlew clients:publishToMavenLocal, then used beyond compare to verify the contents.Committer Checklist (excluded from commit message)